Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGPathElement.cpp

Issue 1541923002: Make SVGElement::propertyFromAttribute return raw pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 if (layoutObject()) 146 if (layoutObject())
147 markForLayoutAndParentResourceInvalidation(layoutObject()); 147 markForLayoutAndParentResourceInvalidation(layoutObject());
148 return; 148 return;
149 } 149 }
150 150
151 SVGGeometryElement::svgAttributeChanged(attrName); 151 SVGGeometryElement::svgAttributeChanged(attrName);
152 } 152 }
153 153
154 void SVGPathElement::collectStyleForPresentationAttribute(const QualifiedName& n ame, const AtomicString& value, MutableStylePropertySet* style) 154 void SVGPathElement::collectStyleForPresentationAttribute(const QualifiedName& n ame, const AtomicString& value, MutableStylePropertySet* style)
155 { 155 {
156 RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute (name); 156 SVGAnimatedPropertyBase* property = propertyFromAttribute(name);
157 if (property == m_path) 157 if (property == m_path)
158 addPropertyToPresentationAttributeStyle(style, CSSPropertyD, m_path->cur rentValue()->pathValue()); 158 addPropertyToPresentationAttributeStyle(style, CSSPropertyD, m_path->cur rentValue()->pathValue());
159 else 159 else
160 SVGGeometryElement::collectStyleForPresentationAttribute(name, value, st yle); 160 SVGGeometryElement::collectStyleForPresentationAttribute(name, value, st yle);
161 } 161 }
162 162
163 void SVGPathElement::invalidateMPathDependencies() 163 void SVGPathElement::invalidateMPathDependencies()
164 { 164 {
165 // <mpath> can only reference <path> but this dependency is not handled in 165 // <mpath> can only reference <path> but this dependency is not handled in
166 // markForLayoutAndParentResourceInvalidation so we update any mpath depende ncies manually. 166 // markForLayoutAndParentResourceInvalidation so we update any mpath depende ncies manually.
(...skipping 12 matching lines...) Expand all
179 return InsertionDone; 179 return InsertionDone;
180 } 180 }
181 181
182 void SVGPathElement::removedFrom(ContainerNode* rootParent) 182 void SVGPathElement::removedFrom(ContainerNode* rootParent)
183 { 183 {
184 SVGGeometryElement::removedFrom(rootParent); 184 SVGGeometryElement::removedFrom(rootParent);
185 invalidateMPathDependencies(); 185 invalidateMPathDependencies();
186 } 186 }
187 187
188 } // namespace blink 188 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGMaskElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGRectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698