src/gpu/gl/GrGLUniformHandler.cpp - Issue 1541903002: added support for PLS path rendering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLUniformHandler.cpp

Issue 1541903002: added support for PLS path rendering (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix for ASAN failure Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/GrGLUniformHandler.cpp

diff --git a/src/gpu/gl/GrGLUniformHandler.cpp b/src/gpu/gl/GrGLUniformHandler.cpp

index 1ddb789668eb023050036b1d8f69e6d35607be18..5335c19da36648aec0847c8322159447f5187ecb 100644

--- a/src/gpu/gl/GrGLUniformHandler.cpp

+++ b/src/gpu/gl/GrGLUniformHandler.cpp

@@ -26,7 +26,7 @@ GrGLSLUniformHandler::UniformHandle GrGLUniformHandler::internalAddUniformArray(

SkDEBUGCODE(static const uint32_t kVisibilityMask = kVertex_Visibility | kFragment_Visibility);

SkASSERT(0 == (~kVisibilityMask & visibility));

SkASSERT(0 != visibility);

- SkASSERT(kDefault_GrSLPrecision == precision || GrSLTypeIsFloatType(type));

+ SkASSERT(kDefault_GrSLPrecision == precision || GrSLTypeIsNumeric(type));

UniformInfo& uni = fUniforms.push_back();

uni.fVariable.setType(type);

« no previous file with comments | « src/gpu/gl/GrGLProgram.cpp ('k') | src/gpu/gl/GrGLVertexArray.h » ('j') | no next file with comments »