PNaCl. Enables x32 libraries for non-sfi runtime.

PNaCl. Enables x32 libraries for non-sfi runtime.


BUG=
R=stichnot@chromium.org

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/344c40b31f16dda0e5e3d7b42ae30bdc3a46d97d

[John, 2015-12-21 17:36:05]

Patchset #1 (id:1) has been deleted

[John, 2015-12-21 22:35:53]

Patchset #4 (id:80001) has been deleted

[John, 2015-12-21 22:35:58]

Patchset #4 (id:100001) has been deleted

[John, 2015-12-21 22:36:05]

Patchset #4 (id:120001) has been deleted

[John, 2015-12-22 17:20:31]

jpp@chromium.org changed reviewers:
+ dschuff@chromium.org, jfb@chromium.org, phosek@chromium.org,
sehr@chromium.org, stichnot@chromium.org

[John, 2015-12-22 17:20:32]

I am git cl re-trying just in case.

[Petr Hosek, 2015-12-22 17:26:41]

https://codereview.chromium.org/1541863002/diff/180001/src/nonsfi/irt/irt_int...
File src/nonsfi/irt/irt_interfaces.c (right):

https://codereview.chromium.org/1541863002/diff/180001/src/nonsfi/irt/irt_int...
src/nonsfi/irt/irt_interfaces.c:248: nacl_irt_off_t *new_offset) {
This could be potentially landed in a separate CL.

https://codereview.chromium.org/1541863002/diff/180001/toolchain_build/pnacl_...
File toolchain_build/pnacl_targetlibs.py (right):

https://codereview.chromium.org/1541863002/diff/180001/toolchain_build/pnacl_...
toolchain_build/pnacl_targetlibs.py:829: 'x86-64-linux':
'%(abs_target_lib_compiler)s/bin/clang',
Couldn't we use clang for other targets as well?

[Jim Stichnoth, 2015-12-22 17:36:28]

https://codereview.chromium.org/1541863002/diff/180001/pnacl/driver/pnacl-tra...
File pnacl/driver/pnacl-translate.py (right):

https://codereview.chromium.org/1541863002/diff/180001/pnacl/driver/pnacl-tra...
pnacl/driver/pnacl-translate.py:286: if base_arch not in ['ARM32', 'X8632',
'X8664']:
This needs more precision about which configurations Subzero supports.

I don't think ARM belongs here at all, for lack of vector support (not to
mention filetype=obj and sandboxing).

X8664 doesn't yet support sandboxing so that should be tested here.

[John, 2015-12-22 18:12:00]

https://codereview.chromium.org/1541863002/diff/180001/pnacl/driver/pnacl-tra...
File pnacl/driver/pnacl-translate.py (right):

https://codereview.chromium.org/1541863002/diff/180001/pnacl/driver/pnacl-tra...
pnacl/driver/pnacl-translate.py:286: if base_arch not in ['ARM32', 'X8632',
'X8664']:
On 2015/12/22 17:36:27, stichnot wrote:
> This needs more precision about which configurations Subzero supports.
> 
> I don't think ARM belongs here at all, for lack of vector support (not to
> mention filetype=obj and sandboxing).
> 
> X8664 doesn't yet support sandboxing so that should be tested here.

I was thinking about that. Reverting for now, until the targets are ready (plus
this is not needed for enabling the x32 unsandboxed runtime build.)

https://codereview.chromium.org/1541863002/diff/180001/src/nonsfi/irt/irt_int...
File src/nonsfi/irt/irt_interfaces.c (right):

https://codereview.chromium.org/1541863002/diff/180001/src/nonsfi/irt/irt_int...
src/nonsfi/irt/irt_interfaces.c:248: nacl_irt_off_t *new_offset) {
On 2015/12/22 17:26:41, Petr Hosek wrote:
> This could be potentially landed in a separate CL.

This is only a problem when building the unsandboxed runtime with clang. Also,
if this change is reverted, then the use of clang for building the unsandboxed
runtime also needs to be reverted.

https://codereview.chromium.org/1541863002/diff/180001/toolchain_build/pnacl_...
File toolchain_build/pnacl_targetlibs.py (right):

https://codereview.chromium.org/1541863002/diff/180001/toolchain_build/pnacl_...
toolchain_build/pnacl_targetlibs.py:829: 'x86-64-linux':
'%(abs_target_lib_compiler)s/bin/clang',
On 2015/12/22 17:26:41, Petr Hosek wrote:
> Couldn't we use clang for other targets as well?

clang fails to build the arm unsandboxed runtime:

@@@BUILD_STEP unsandboxed_runtime_arm_linux (build)@@@
Running:
subprocess.check_call(['/usr/local/google/home/jpp/work/nacl/native_client/toolchain_build/out/target_lib_compiler_install/target_lib_compiler/bin/clang',
'-target=arm-linux-gnueabihf', '-mcpu=cortex-a9', '-D__arm_nonsfi_linux__',
'-O2', '-Wall', '-Werror', '-I../../../..', '-DNACL_LINUX=1', '-DDEFINE_MAIN',
'-c', '../../../src/nonsfi/irt/irt_interfaces.c', '-o',
'../unsandboxed_runtime_arm_linux_install/translator/arm-linux/lib/unsandboxed_irt.o'],
cwd='/usr/local/google/home/jpp/work/nacl/native_client/toolchain_build/out/unsandboxed_runtime_arm_linux_work')
In file included from ../../../src/nonsfi/irt/irt_interfaces.c:11:
/usr/include/pthread.h:692:6: error: 'regparm' is not valid on this platform
     __cleanup_fct_attribute;
     ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/bits/pthreadtypes.h:246:50: note: expanded from macro
'__cleanup_fct_attribute'
# define __cleanup_fct_attribute __attribute__ ((__regparm__ (1)))
                                                 ^            ~
In file included from ../../../src/nonsfi/irt/irt_interfaces.c:11:
/usr/include/pthread.h:704:3: error: 'regparm' is not valid on this platform
  __cleanup_fct_attribute;
  ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/bits/pthreadtypes.h:246:50: note: expanded from macro
'__cleanup_fct_attribute'
# define __cleanup_fct_attribute __attribute__ ((__regparm__ (1)))
                                                 ^            ~
In file included from ../../../src/nonsfi/irt/irt_interfaces.c:11:
/usr/include/pthread.h:745:6: error: 'regparm' is not valid on this platform
     __cleanup_fct_attribute __attribute__ ((__noreturn__))
     ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/bits/pthreadtypes.h:246:50: note: expanded from macro
'__cleanup_fct_attribute'
# define __cleanup_fct_attribute __attribute__ ((__regparm__ (1)))
                                                 ^            ~
3 errors generated.
Error building unsandboxed_runtime_arm_linux: Command
'['/usr/local/google/home/jpp/work/nacl/native_client/toolchain_build/out/target_lib_compiler_install/target_lib_compiler/bin/clang',
'-target=arm-linux-gnueabihf', '-mcpu=cortex-a9', '-D__arm_nonsfi_linux__',
'-O2', '-Wall', '-Werror', '-I../../../..', '-DNACL_LINUX=1', '-DDEFINE_MAIN',
'-c', '../../../src/nonsfi/irt/irt_interfaces.c', '-o',
'../unsandboxed_runtime_arm_linux_install/translator/arm-linux/lib/unsandboxed_irt.o']'
returned non-zero exit status 1

So I'll leave this as is.

[Jim Stichnoth, 2015-12-22 20:10:26]

lgtm

[John, 2015-12-23 17:21:37]

Description was changed from

==========
PNaCl. Enables x32 libraries for non-sfi runtime.


BUG=
==========

to

==========
PNaCl. Enables x32 libraries for non-sfi runtime.


BUG=
R=stichnot@chromium.org

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/344c40b31...
==========

[John, 2015-12-23 17:21:38]

Committed patchset #7 (id:200001) manually as
344c40b31f16dda0e5e3d7b42ae30bdc3a46d97d (presubmit successful).