Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 1541843002: Autofill's CountryCode should use scoped_ptr for owned pointers (Closed)

Created:
5 years ago by vabr (Chromium)
Modified:
5 years ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill's CountryCode should use scoped_ptr for owned pointers This CL turns a map of raw pointers to a map of scoped_ptrs. It is a clean-up which is unlikely to fix the associated crash, but the explicit semantics might help discover the real cause. And besides, using scopers for owned pointers is a good practice. BUG=571371 Committed: https://crrev.com/e35c03b8f0a01e5882596b4527feeee2d4f5bd7d Cr-Commit-Position: refs/heads/master@{#366414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M components/autofill/core/browser/autofill_country.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M components/autofill/core/common/autofill_l10n_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/autofill_l10n_util.cc View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vabr (Chromium)
Hello mathp@, Please take a look. Cheers, Vaclav
5 years ago (2015-12-21 16:43:06 UTC) #2
Mathieu
lgtm, thanks for the cleanup!
5 years ago (2015-12-21 16:45:41 UTC) #3
vabr (Chromium)
Thanks! The compile errors on trybots seem unrelated, so sending this to the CQ. Cheers, ...
5 years ago (2015-12-21 16:49:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541843002/1
5 years ago (2015-12-21 16:50:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 17:48:38 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-21 17:49:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e35c03b8f0a01e5882596b4527feeee2d4f5bd7d
Cr-Commit-Position: refs/heads/master@{#366414}

Powered by Google App Engine
This is Rietveld 408576698