Record Chrome trace events in tcmalloc heap profiles

content/browser/browser_main_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_main_loop.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/hi_res_timer_manager.h"
@@ skipping 463 matching lines @@
     TRACE_EVENT0("startup", "BrowserMainLoop::Subsystem:DataFetcher")
     DataFetcherImplAndroid::Init(base::android::AttachCurrentThread());
   }
 #endif
 
   if (parsed_command_line_.HasSwitch(switches::kMemoryMetrics)) {
     TRACE_EVENT0("startup", "BrowserMainLoop::Subsystem:MemoryObserver")
     memory_observer_.reset(new MemoryObserver());
     base::MessageLoop::current()->AddTaskObserver(memory_observer_.get());
   }
+
+  // TODO(jamescook): Support all tcmalloc platforms, including Windows.

[nduca, 2013/06/20 20:09:29]

How about always creating it, but have the observe do nothing if its not
supported? Then the goup about supported only goes inisde the observer...

[James Cook, 2013/06/29 00:02:42]

Done. Also consolidated all the macro craziness into a single
TRACE_MEMORY_SUPPORTED macro.

+#if defined(USE_TCMALLOC) && (defined(OS_LINUX) || defined(OS_ANDROID))
+  trace_memory_observer_.reset(new base::debug::TraceMemoryTraceLogObserver(
+      base::MessageLoop::current()->message_loop_proxy()));
+#endif

[dsinclair, 2013/06/18 15:30:15]

Does this also need to be done in places like the GPU process?

[James Cook, 2013/06/29 00:02:42]

Probably. I think I can shim this in around GpuMain, but could use some advice
on whether that's the right place or not.

 }
 
 void BrowserMainLoop::CreateThreads() {
   TRACE_EVENT0("startup", "BrowserMainLoop::CreateThreads")
 
   if (parts_) {
     TRACE_EVENT0("startup",
         "BrowserMainLoop::MainMessageLoopStart:PreCreateThreads");
     result_code_ = parts_->PreCreateThreads();
   }
@@ skipping 136 matching lines @@
   // need to be able to perform IO.
   base::ThreadRestrictions::SetIOAllowed(true);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(base::IgnoreResult(&base::ThreadRestrictions::SetIOAllowed),
                  true));
 
   if (parts_)
     parts_->PostMainMessageLoopRun();
 
+  // TODO(jamescook): Support all tcmalloc platforms, including Windows.
+#if defined(USE_TCMALLOC) && (defined(OS_LINUX) || defined(OS_ANDROID))
+  trace_memory_observer_.reset();
+#endif
+
 #if !defined(OS_IOS)
   // Destroying the GpuProcessHostUIShims on the UI thread posts a task to
   // delete related objects on the GPU thread. This must be done before
   // stopping the GPU thread. The GPU thread will close IPC channels to renderer
   // processes so this has to happen before stopping the IO thread.
   GpuProcessHostUIShim::DestroyAll();
 
   // Cancel pending requests and prevent new requests.
   if (resource_dispatcher_host_)
     resource_dispatcher_host_.get()->Shutdown();
@@ skipping 267 matching lines @@
   if (parameters_.ui_task)
     base::MessageLoopForUI::current()->PostTask(FROM_HERE,
                                                 *parameters_.ui_task);
 
   base::RunLoop run_loop;
   run_loop.Run();
 #endif
 }
 
 }  // namespace content