Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1541753002: HTMLOptionElement.prototype.selected setter should not make an option dirty if it doesn't change it… (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HTMLOptionElement.prototype.selected setter should not make an option dirty if it doesn't change its selectedness and the option is owned by a select element. We implmeneted option dirtiness in [1] and it conformed to the standard. However, it was not compatible with other browsers and caused a regression. This CL makes the dirtiness behavior compatible with Firefox. [1] crrev.com/363172 BUG=570367 TEST=automated Committed: https://crrev.com/f67251360e4b76d188bb1523d7a0952c2f449e68 Cr-Commit-Position: refs/heads/master@{#366784}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/select/option-dirtiness.html View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.cpp View 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
tkent
Keishi, would you review this please?
5 years ago (2015-12-21 07:39:29 UTC) #2
keishi
LGTM
5 years ago (2015-12-23 12:08:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541753002/1
5 years ago (2015-12-23 23:02:18 UTC) #5
tfarina
https://codereview.chromium.org/1541753002/diff/1/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp File third_party/WebKit/Source/core/html/HTMLOptionElement.cpp (right): https://codereview.chromium.org/1541753002/diff/1/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp#newcode273 third_party/WebKit/Source/core/html/HTMLOptionElement.cpp:273: // As of December 2015, the HTML specification says ...
5 years ago (2015-12-23 23:04:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-24 00:28:32 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-24 00:29:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f67251360e4b76d188bb1523d7a0952c2f449e68
Cr-Commit-Position: refs/heads/master@{#366784}

Powered by Google App Engine
This is Rietveld 408576698