Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 1541733002: Android OIB: Do not show Certificate Viewer for http connections (Closed)

Created:
5 years ago by tsergeant
Modified:
4 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android OIB: Do not show Certificate Viewer for http connections The flag "treat non-secure origins as non-secure" allows connection info popup to be opened for HTTP connections. This patch ensures that the certificate viewer cannot be opened for these connections. In the longer term, we may want to change or remove the connection info popup for insecure HTTP connections. BUG=563619 Committed: https://crrev.com/ff871463fd5232dd9fda8dee21bdf7adb3e08655 Cr-Commit-Position: refs/heads/master@{#372247}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/android/java/res/layout/connection_info.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/connection_info_popup_android.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tsergeant
Please take a look!
4 years, 10 months ago (2016-01-28 23:28:07 UTC) #5
Ted C
lgtm
4 years, 10 months ago (2016-01-29 01:08:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541733002/40001
4 years, 10 months ago (2016-01-29 01:42:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 10 months ago (2016-01-29 01:48:54 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 01:49:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff871463fd5232dd9fda8dee21bdf7adb3e08655
Cr-Commit-Position: refs/heads/master@{#372247}

Powered by Google App Engine
This is Rietveld 408576698