Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 1541713002: Revert of Support device scale factor test with popups in LayoutTest (Closed)

Created:
5 years ago by Noel Gordon
Modified:
5 years ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, tdanderson+views_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support device scale factor test with popups in LayoutTest (patchset #2 id:40001 of https://codereview.chromium.org/1525933002/ ) Reason for revert: Looking into http://crbug.com/570401 where the auto-rebaseline server seems to be generating some baselines with a root layer size of 1600x1200 rather than 800x600, or is producing all white image results. It started around the time this change went in. Reverting here to attempt to restore the rebaseline server. Skip all "dfs2" in TextExpectations, add FIXME notes. Original issue's description: > Support device scale factor test with popups in LayoutTest > > * Sends DSF to host so that host can send a resize request with requested DSF. > * Updated X11's screen so that displays contains specified DSF. > This is used by RWH to construct WebScreenInfo with updated DSF. > - Win/Mac will use the DSF specified by command line flag. > * Scale the popup location based on the device scale factor. > This is done by compositor in normal scenario. > > BUG=567837 > TEST=added popu-menu-appearance-dsf2.html > > Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa > Cr-Commit-Position: refs/heads/master@{#365647} TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromium.org,oshima@chromium.org BUG=567837, 570401 Committed: https://crrev.com/8ab1ead46c6add1bc2afe0d4ea969841bd15f35f Cr-Commit-Position: refs/heads/master@{#366318}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -134 lines) Patch
M components/html_viewer/web_test_delegate_impl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/html_viewer/web_test_delegate_impl.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/browser/blink_test_controller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/blink_test_controller.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/shell/browser/shell.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/browser/shell.cc View 1 3 chunks +0 lines, -20 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 4 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +6 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/hidpi/popup-menu-appearance-dsf2.html View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-lion/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mountainlion/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-snowleopard/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/hidpi/popup-menu-appearance-dsf2-expected.txt View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/hidpi/popup-menu-appearance-dsf2-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/hidpi/popup-menu-appearance-dsf2-expected.txt View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Noel Gordon
Created Revert of Support device scale factor test with popups in LayoutTest
5 years ago (2015-12-20 23:58:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541713002/1
5 years ago (2015-12-20 23:58:58 UTC) #2
commit-bot: I haz the power
Failed to apply patch for content/shell/browser/shell.cc: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-12-20 23:59:28 UTC) #5
Noel Gordon
Will try by hand then.
5 years ago (2015-12-21 00:15:45 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541713002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541713002/280001
5 years ago (2015-12-21 00:44:03 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-21 01:39:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541713002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541713002/280001
5 years ago (2015-12-21 01:39:50 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:280001)
5 years ago (2015-12-21 01:44:09 UTC) #18
commit-bot: I haz the power
5 years ago (2015-12-21 01:45:12 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8ab1ead46c6add1bc2afe0d4ea969841bd15f35f
Cr-Commit-Position: refs/heads/master@{#366318}

Powered by Google App Engine
This is Rietveld 408576698