Revert of Support device scale factor test with popups in LayoutTest (patchset #2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server. Skip all "dfs2" in TextExpectations, add
FIXME notes.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromium.org,oshima@chromium.org
BUG=567837, 570401
Committed: https://crrev.com/8ab1ead46c6add1bc2afe0d4ea969841bd15f35f
Cr-Commit-Position: refs/heads/master@{#366318}
Created Revert of Support device scale factor test with popups in LayoutTest
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541713002/1
Description was changed from
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567837
==========
to
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567837, 570401
==========
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
Description was changed from
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567837, 570401
==========
to
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567837, 570401
==========
Description was changed from
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567837, 570401
==========
to
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
BUG=567837, 570401
==========
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541713002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541713002/280001
Description was changed from
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
BUG=567837, 570401
==========
to
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server. Skip all "dfs2" in TextExpectations, add
FIXME notes.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
BUG=567837, 570401
==========
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541713002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541713002/280001
Description was changed from
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server. Skip all "dfs2" in TextExpectations, add
FIXME notes.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
BUG=567837, 570401
==========
to
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server. Skip all "dfs2" in TextExpectations, add
FIXME notes.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
BUG=567837, 570401
==========
Description was changed from
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server. Skip all "dfs2" in TextExpectations, add
FIXME notes.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
BUG=567837, 570401
==========
to
==========
Revert of Support device scale factor test with popups in LayoutTest (patchset
#2 id:40001 of https://codereview.chromium.org/1525933002/ )
Reason for revert:
Looking into http://crbug.com/570401 where the auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in. Reverting here to attempt to
restore the rebaseline server. Skip all "dfs2" in TextExpectations, add
FIXME notes.
Original issue's description:
> Support device scale factor test with popups in LayoutTest
>
> * Sends DSF to host so that host can send a resize request with requested DSF.
> * Updated X11's screen so that displays contains specified DSF.
> This is used by RWH to construct WebScreenInfo with updated DSF.
> - Win/Mac will use the DSF specified by command line flag.
> * Scale the popup location based on the device scale factor.
> This is done by compositor in normal scenario.
>
> BUG=567837
> TEST=added popu-menu-appearance-dsf2.html
>
> Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
> Cr-Commit-Position: refs/heads/master@{#365647}
TBR=mkwst@chromium.org,sadrul@chromium.org,tkent@chromium.org,wkorman@chromiu...
BUG=567837, 570401
Committed: https://crrev.com/8ab1ead46c6add1bc2afe0d4ea969841bd15f35f
Cr-Commit-Position: refs/heads/master@{#366318}
==========
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8ab1ead46c6add1bc2afe0d4ea969841bd15f35f Cr-Commit-Position: refs/heads/master@{#366318}
Issue 1541713002: Revert of Support device scale factor test with popups in LayoutTest
(Closed)
Created 5 years ago by Noel Gordon
Modified 5 years ago
Reviewers: Mike West, sadrul, tkent, wkorman, oshima
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0