Reland "arc-bridge: Move most methods to Mojo interfaces"

components/arc/arc_bridge_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/run_loop.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
@@ skipping 50 matching lines @@
 
       case ArcBridgeService::State::STOPPED:
         message_loop_.PostTask(FROM_HERE, message_loop_.QuitWhenIdleClosure());
         break;
 
       default:
         break;
     }
   }
 
-  void OnInstanceBootPhase(InstanceBootPhase boot_phase) override {
-    boot_phase_ = boot_phase;
-  }
-
   bool ready() const { return ready_; }
-  InstanceBootPhase boot_phase() const { return boot_phase_; }
   ArcBridgeService::State state() const { return state_; }
 
  protected:
   scoped_ptr<ArcBridgeService> service_;
   scoped_ptr<FakeArcBridgeInstance> instance_;
 
  private:
   void SetUp() override {
     chromeos::DBusThreadManager::Initialize();
 
     ready_ = false;
     state_ = ArcBridgeService::State::STOPPED;
-    boot_phase_ = INSTANCE_BOOT_PHASE_NOT_RUNNING;
 
     ipc_support_.reset(new IPC::ScopedIPCSupport(message_loop_.task_runner()));
     instance_.reset(new FakeArcBridgeInstance());
     service_.reset(new ArcBridgeServiceImpl(
         make_scoped_ptr(new FakeArcBridgeBootstrap(instance_.get()))));
 
     service_->AddObserver(this);
   }
 
   void TearDown() override {
     service_->RemoveObserver(this);
     instance_.reset();
     service_.reset();
     ipc_support_.reset();
 
     chromeos::DBusThreadManager::Shutdown();
   }
 
   bool ready_;
-  InstanceBootPhase boot_phase_;
   ArcBridgeService::State state_;
   scoped_ptr<IPC::ScopedIPCSupport> ipc_support_;
   base::MessageLoopForUI message_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBridgeTest);
 };
 
 // Shuts down the instance reports booted.
-class ScopedShutdownWhenBooted : public ArcBridgeService::Observer {
+class ScopedShutdownWhenReady : public ArcBridgeService::Observer {
  public:
-  explicit ScopedShutdownWhenBooted(ArcBridgeService* service)
+  explicit ScopedShutdownWhenReady(ArcBridgeService* service)
       : service_(service) {
     service_->AddObserver(this);
   }
 
-  ~ScopedShutdownWhenBooted() override { service_->RemoveObserver(this); }
+  ~ScopedShutdownWhenReady() override { service_->RemoveObserver(this); }
 
-  void OnInstanceBootPhase(InstanceBootPhase boot_phase) override {
-    if (boot_phase == INSTANCE_BOOT_PHASE_BOOT_COMPLETED) {
+  void OnStateChanged(ArcBridgeService::State state) override {
+    if (state == ArcBridgeService::State::READY) {
       service_->Shutdown();
     }
   }
 
  private:
   ArcBridgeService* service_;
 
-  DISALLOW_COPY_AND_ASSIGN(ScopedShutdownWhenBooted);
+  DISALLOW_COPY_AND_ASSIGN(ScopedShutdownWhenReady);
 };
 
 // Exercises the basic functionality of the ARC Bridge Service.  A message from
 // within the instance should cause the observer to be notified.
 TEST_F(ArcBridgeTest, Basic) {
   ASSERT_FALSE(ready());
   ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
 
-  ScopedShutdownWhenBooted shutdown(service_.get());
+  ScopedShutdownWhenReady shutdown(service_.get());
 
   service_->SetAvailable(true);
   service_->HandleStartup();
 
-  ASSERT_EQ(ArcBridgeService::State::CONNECTED, state());
+  ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
 
   base::RunLoop run_loop;
   run_loop.Run();
 
   EXPECT_TRUE(ready());
-  ASSERT_EQ(INSTANCE_BOOT_PHASE_BOOT_COMPLETED, boot_phase());
   ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
 }
 
 // If not all pre-requisites are met, the instance is not started.
 TEST_F(ArcBridgeTest, Prerequisites) {
   ASSERT_FALSE(ready());
   ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
   service_->SetAvailable(true);
   ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
   service_->SetAvailable(false);
   service_->HandleStartup();
   ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
 }
 
 // If the ArcBridgeService is shut down, it should be stopped, even
 // mid-startup.
 TEST_F(ArcBridgeTest, ShutdownMidStartup) {
   ASSERT_FALSE(ready());
 
   service_->SetAvailable(true);
   service_->HandleStartup();
 
-  ASSERT_EQ(ArcBridgeService::State::CONNECTED, state());
+  ASSERT_EQ(ArcBridgeService::State::READY, state());
   service_->Shutdown();
   // Some machines can reach the STOPPED state immediately.
   ASSERT_TRUE(state() == ArcBridgeService::State::STOPPING ||
               state() == ArcBridgeService::State::STOPPED);
 
   base::RunLoop run_loop;
   run_loop.Run();
 
   ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
 }
 
 }  // namespace arc