Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 154153008: Use exception instead of sys.exit(). (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Use exception instead of sys.exit(). Addresses a review comment from frankf at https://codereview.chromium.org/157743004/ BUG=142642 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250302

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M build/android/pylib/gtest/test_package_exe.py View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 10 months ago (2014-02-10 23:18:58 UTC) #1
frankf
lgtm. Thanks.
6 years, 10 months ago (2014-02-10 23:33:43 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 10 months ago (2014-02-10 23:50:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/154153008/20001
6 years, 10 months ago (2014-02-11 00:07:37 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 02:52:14 UTC) #5
Message was sent while issue was closed.
Change committed as 250302

Powered by Google App Engine
This is Rietveld 408576698