Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1541513002: Switch from build-time to run-time flags for Project Spitzer. (Closed)

Created:
5 years ago by xhwang
Modified:
5 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch from build-time to run-time flags for Project Spitzer. Contributed by dalecurtis@chromium.org. This puts the desktop media playback pipeline behind a runtime flag for Android; previously this was a combination of build-time and run-time flags to avoid introducing a binary size increase before we were ready for experiments. This change will result in a ~480kb apk size increase on Android that has been approved via Chrome Eng Review and klobag@ from the Chrome for Android team. http://crbug.com/570711 tracks this size increase and plans to reduce it in the future. It paves the way for unifying our playback stacks across platforms and brings previously-missing features and improved security to Android playback. More technical details can be found in the linked bug below and design doc: https://goo.gl/qC3OuL BUG=507834, 570711, 570762 TEST=builds with gn/gyp work with unified path. TBR=grt@chromium.org,dpranke@chromium.org,liberato@chromium.org,creis@chromium.org Committed: https://crrev.com/fa2d9d4704677627af5c703fc4c04717f5425e4a Cr-Commit-Position: refs/heads/master@{#366208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -89 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 6 chunks +3 lines, -13 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 6 chunks +8 lines, -20 lines 0 comments Download
M media/BUILD.gn View 3 chunks +13 lines, -11 lines 0 comments Download
M media/base/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M media/media.gyp View 5 chunks +21 lines, -19 lines 0 comments Download
M media/media_options.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M media/media_variables.gypi View 1 chunk +7 lines, -5 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 3 chunks +1 line, -6 lines 0 comments Download
M media/test/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
xhwang
This is the rebase of https://chromiumcodereview.appspot.com/1530063002/. Sorry, I can't upload a new PS to an ...
5 years ago (2015-12-18 21:53:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541513002/1
5 years ago (2015-12-18 22:00:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 23:31:26 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fa2d9d4704677627af5c703fc4c04717f5425e4a Cr-Commit-Position: refs/heads/master@{#366208}
5 years ago (2015-12-18 23:32:20 UTC) #10
Dirk Pranke
lgtm
5 years ago (2015-12-19 19:52:34 UTC) #11
DaleCurtis
5 years ago (2015-12-19 20:30:09 UTC) #12
Message was sent while issue was closed.
Looks like there was an uncaught issue on the android x86 builders:
https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builde...

Fix in the CQ here:
https://codereview.chromium.org/1540713002/

Powered by Google App Engine
This is Rietveld 408576698