Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1541473002: Revert of Pull the Activity context from WindowAndroid if possible (Closed)

Created:
5 years ago by dtu
Modified:
5 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pull the Activity context from WindowAndroid if possible (patchset #4 id:60001 of https://codereview.chromium.org/1528733002/ ) Reason for revert: Failing on perf Android Builders. https://build.chromium.org/p/chromium.perf/builders/Android%20Builder/builds/56908 https://build.chromium.org/p/chromium.perf/builders/Android%20arm64%20Builder/builds/14488 Original issue's description: > Pull the Activity context from WindowAndroid if possible > > WebView uses ContentViewCore's context for displaying dialogs and > wraps it at construction time. This change makes sure that if there > is an activity that can be reached through WindowAndroid, we use > that as the context inside ColorChooser. Also make sure if there is no activity, we > dont attempt to create a color chooser and try to show it. > Update ActivityWindowAndroid to take a Context type so > that in Android WebView, the activity context can remain wrapped. > > BUG=550410, 570429 > > Committed: https://crrev.com/fdf17ed2da4f4554400c25993aa688cb9355c004 > Cr-Commit-Position: refs/heads/master@{#366125} TBR=boliu@chromium.org,torne@chromium.org,tedchoc@chromium.org,tobiasjs@chromium.org,newt@chromium.org,yusufo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=550410, 570429 Committed: https://crrev.com/b370242ecaeee80710008a3e1927fcd1d73f568e Cr-Commit-Position: refs/heads/master@{#366159}

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
dtu
Created Revert of Pull the Activity context from WindowAndroid if possible
5 years ago (2015-12-18 20:23:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541473002/1
5 years ago (2015-12-18 20:24:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 20:25:28 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-18 20:26:43 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b370242ecaeee80710008a3e1927fcd1d73f568e
Cr-Commit-Position: refs/heads/master@{#366159}

Powered by Google App Engine
This is Rietveld 408576698