Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serialize frames, not pages and therefore
their old names (WebPageSerializer, PageSerializer, etc) do not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766, 526786
Committed: https://crrev.com/902fcc5c3732cf387828f7e0c10a810e5bf85714
Cr-Commit-Position: refs/heads/master@{#367227}

[Łukasz Anforowicz, 2015-12-18 19:56:08]

Description was changed from

==========
Rename PageSerializer to FrameSerializer where applicable.

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serializer frames, not pages and therefore
their old name (WebPageSerializer, PageSerializer, etc) does not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766 526786
==========

to

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serializer frames, not pages and therefore
their old name (WebPageSerializer, PageSerializer, etc) does not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766 526786
==========

[Łukasz Anforowicz, 2015-12-18 20:43:28]

Description was changed from

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serializer frames, not pages and therefore
their old name (WebPageSerializer, PageSerializer, etc) does not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766 526786
==========

to

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serializer frames, not pages and therefore
their old name (WebPageSerializer, PageSerializer, etc) does not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766,526786
==========

[Łukasz Anforowicz, 2015-12-31 00:59:08]

Description was changed from

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serializer frames, not pages and therefore
their old name (WebPageSerializer, PageSerializer, etc) does not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766,526786
==========

to

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serializer frames, not pages and therefore
their old name (WebPageSerializer, PageSerializer, etc) does not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766,526786
==========

[Łukasz Anforowicz, 2015-12-31 01:04:49]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2015-12-31 01:04:50]

Daniel, could you please take a look?

[Łukasz Anforowicz, 2015-12-31 01:06:13]

Description was changed from

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serializer frames, not pages and therefore
their old name (WebPageSerializer, PageSerializer, etc) does not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766,526786
==========

to

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serialize frames, not pages and therefore
their old names (WebPageSerializer, PageSerializer, etc) do not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766,526786
==========

[Łukasz Anforowicz, 2015-12-31 01:06:38]

+yosin@ as FYI

[dcheng, 2015-12-31 01:12:39]

lgtm

[Łukasz Anforowicz, 2015-12-31 01:20:51]

nasko@, could you please take a look at:
    content/browser/download/mhtml_generation_manager.cc
    content/renderer/dom_serializer_browsertest.cc
    content/renderer/render_frame_impl.cc
    content/renderer/render_frame_impl.h

[nasko, 2015-12-31 01:23:25]

nasko@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2015-12-31 01:23:25]

Rubberstamp LGTM.

[Łukasz Anforowicz, 2015-12-31 03:30:10]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2015-12-31 03:30:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541463002/20001

[commit-bot: I haz the power, 2015-12-31 04:45:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-31 04:46:42]

Description was changed from

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serialize frames, not pages and therefore
their old names (WebPageSerializer, PageSerializer, etc) do not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766,526786
==========

to

==========
Rename [Web]PageSerializer[Test|Client|Impl] to ...FrameSerializer...

After refactoring needed to support OOPIFs in save-page-as feature, the
html serializers in blink serialize frames, not pages and therefore
their old names (WebPageSerializer, PageSerializer, etc) do not apply
anymore.  Therefore this CL renames PageSerializer to FrameSerializer
where applicable.

Note that this rename not only covers PageSerializer class, but also
WebPageSerializer, WebPageSerializerClient, PageSerializerTest, test
data files, etc.

Note that FrameSerializer is more correct than HtmlSerializer, because
- FrameSerializer also serializes subresources (i.e. images)
- Even though WebFrameSerializerImpl deals only with HTML documents,
  for now it might make sense to leave it named as WebFrameSerializerImpl:
  - it still takes a Frame as input
  - it implements part of the public WebFrameSerializer class
    (and therefore it is desirable to have a similar name here as well)

BUG=538766,526786

Committed: https://crrev.com/902fcc5c3732cf387828f7e0c10a810e5bf85714
Cr-Commit-Position: refs/heads/master@{#367227}
==========

[commit-bot: I haz the power, 2015-12-31 04:46:43]

Patchset 2 (id:??) landed as
https://crrev.com/902fcc5c3732cf387828f7e0c10a810e5bf85714
Cr-Commit-Position: refs/heads/master@{#367227}