Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1541453002: Error code validation updates. (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Error code validation updates. Updates validation to handle configured severities (`error`, `info`, and `warning`). R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/34780784f212aaec01c8c8ceacf7ea8dabd4216a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M pkg/analyzer/lib/source/error_processor.dart View 1 chunk +8 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 4 chunks +19 lines, -11 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years ago (2015-12-18 20:46:25 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-18 20:53:37 UTC) #3
pquitslund
5 years ago (2015-12-18 20:58:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34780784f212aaec01c8c8ceacf7ea8dabd4216a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698