Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py

Issue 1541443004: Telemetry: Update webrtc_rendering_timeline.py metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py b/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py
index b49563e6caa1bf31d02028ec4235c85e6088f28b..062ef09c274f667f94f9518d6edead2e5d1db72e 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py
@@ -58,6 +58,7 @@ class WebRtcRenderingTimelineMetric(timeline_based_metric.TimelineBasedMetric):
rendering_stats.drift_time,
important=True,
description='Drift time for a rendered frame',
+ tir_label=interactions[0].label,
improvement_direction=improvement_direction.DOWN,
none_value_reason=none_reason))
@@ -68,6 +69,7 @@ class WebRtcRenderingTimelineMetric(timeline_based_metric.TimelineBasedMetric):
rendering_stats.percent_badly_out_of_sync,
important=True,
description='Percentage of frame which drifted more than 2 VSYNC',
+ tir_label=interactions[0].label,
improvement_direction=improvement_direction.DOWN,
none_value_reason=none_reason))
@@ -78,6 +80,7 @@ class WebRtcRenderingTimelineMetric(timeline_based_metric.TimelineBasedMetric):
rendering_stats.percent_out_of_sync,
important=True,
description='Percentage of frame which drifted more than 1 VSYNC',
+ tir_label=interactions[0].label,
improvement_direction=improvement_direction.DOWN,
none_value_reason=none_reason))
@@ -92,6 +95,7 @@ class WebRtcRenderingTimelineMetric(timeline_based_metric.TimelineBasedMetric):
rendering_stats.fps,
important=True,
description='Calculated Frame Rate of video rendering',
+ tir_label=interactions[0].label,
improvement_direction=improvement_direction.UP,
none_value_reason=none_reason))
@@ -102,6 +106,7 @@ class WebRtcRenderingTimelineMetric(timeline_based_metric.TimelineBasedMetric):
rendering_stats.smoothness_score,
important=True,
description='Smoothness score of rendering',
+ tir_label=interactions[0].label,
improvement_direction=improvement_direction.UP,
none_value_reason=none_reason))
@@ -112,6 +117,7 @@ class WebRtcRenderingTimelineMetric(timeline_based_metric.TimelineBasedMetric):
rendering_stats.freezing_score,
important=True,
description='Freezing score of rendering',
+ tir_label=interactions[0].label,
improvement_direction=improvement_direction.UP,
none_value_reason=none_reason))
@@ -122,5 +128,6 @@ class WebRtcRenderingTimelineMetric(timeline_based_metric.TimelineBasedMetric):
rendering_stats.rendering_length_error,
important=True,
description='Rendering length error rate',
+ tir_label=interactions[0].label,
improvement_direction=improvement_direction.DOWN,
none_value_reason=none_reason))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698