Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1541443002: Fix small bugs in new CSS Property parser (Closed)

Created:
5 years ago by rwlbuis
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix small bugs in new CSS Property parser Fix small bugs in new CSS Property parser: - for flex and -webkit-columns, reject whitespace only values. - for will-change, fix roundtripping by generating a CSSPrimitiveValue. - for counter-increment, serialize using space separated lists and integer type [1]. - for cursor, require a keyword after the comma. Add various test for these fixes. BUG=568435 [1] https://drafts.csswg.org/css-lists-3/#counter-properties Committed: https://crrev.com/a20f0a89a92c3e94cd35a4026fafd5653bd6b43b Cr-Commit-Position: refs/heads/master@{#368028}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : V3 #

Patch Set 4 : V4 #

Total comments: 6

Patch Set 5 : Address review comments #

Messages

Total messages: 12 (5 generated)
rwlbuis
PTAL.
4 years, 11 months ago (2016-01-05 04:51:57 UTC) #3
Timothy Loh
https://codereview.chromium.org/1541443002/diff/60001/third_party/WebKit/LayoutTests/css-parser/whitespace-declaration.html File third_party/WebKit/LayoutTests/css-parser/whitespace-declaration.html (right): https://codereview.chromium.org/1541443002/diff/60001/third_party/WebKit/LayoutTests/css-parser/whitespace-declaration.html#newcode5 third_party/WebKit/LayoutTests/css-parser/whitespace-declaration.html:5: <script> Can we use testharness instead of js-test? Otherwise ...
4 years, 11 months ago (2016-01-06 00:14:52 UTC) #4
rwlbuis
I addressed the review comments, PTAL. https://codereview.chromium.org/1541443002/diff/60001/third_party/WebKit/LayoutTests/css-parser/whitespace-declaration.html File third_party/WebKit/LayoutTests/css-parser/whitespace-declaration.html (right): https://codereview.chromium.org/1541443002/diff/60001/third_party/WebKit/LayoutTests/css-parser/whitespace-declaration.html#newcode5 third_party/WebKit/LayoutTests/css-parser/whitespace-declaration.html:5: <script> On 2016/01/06 ...
4 years, 11 months ago (2016-01-06 08:11:03 UTC) #5
Timothy Loh
lgtm, sorry for the delay (and I know you still have a patch up I ...
4 years, 11 months ago (2016-01-07 03:15:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541443002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541443002/80001
4 years, 11 months ago (2016-01-07 06:10:53 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-07 07:42:40 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 07:43:58 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a20f0a89a92c3e94cd35a4026fafd5653bd6b43b
Cr-Commit-Position: refs/heads/master@{#368028}

Powered by Google App Engine
This is Rietveld 408576698