Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1541413002: [runtime] Add Arguments.atOrUndefined() (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Add Arguments.atOrUndefined() atOrUndefined() will return undefined if the index is >= length() BUG= Committed: https://crrev.com/0bd4131426a84d00c70ccc63aa3afde2473ecaf3 Cr-Commit-Position: refs/heads/master@{#33033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M src/builtins.cc View 5 chunks +15 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Camillo Bruni
PTAL
5 years ago (2015-12-23 17:16:46 UTC) #2
Igor Sheludko
lgtm
5 years ago (2015-12-23 17:50:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541413002/1
5 years ago (2015-12-23 19:07:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 19:29:01 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-23 19:29:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bd4131426a84d00c70ccc63aa3afde2473ecaf3
Cr-Commit-Position: refs/heads/master@{#33033}

Powered by Google App Engine
This is Rietveld 408576698