Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 15414004: When recording the type of a captured variable/parameter, use the closure field it maps to. Otherwi… (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
karlklose, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

When recording the type of a captured variable/parameter, use the closure field it maps to. Otherwise, there is a confusion for a parameter between the type given by its callers, and the actual type in the method, where the parameter can be updated explictly, or implicitly by the inferrer on "is checks". R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=22939

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -34 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 1 2 9 chunks +44 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 2 11 chunks +24 lines, -20 lines 0 comments Download
A tests/language/issue10721_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ngeoffray
7 years, 7 months ago (2013-05-19 11:53:24 UTC) #1
karlklose
LGTM.
7 years, 7 months ago (2013-05-21 09:08:26 UTC) #2
ngeoffray
Thanks Karl. Could you please PTAL? After merging with trunk, I had to fix a ...
7 years, 7 months ago (2013-05-21 10:00:42 UTC) #3
karlklose
SLGTM.
7 years, 7 months ago (2013-05-21 10:35:20 UTC) #4
ngeoffray
7 years, 7 months ago (2013-05-21 14:09:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r22939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698