third_party/WebKit/Source/platform/fonts/Character.h - Issue 1541393003: Improve performance of Character::isCJKIdeographOrSymbol by using trie tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/Character.h

Issue 1541393003: Improve performance of Character::isCJKIdeographOrSymbol by using trie tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup, remove isCJKIdeograph, remove perf test code Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/fonts/Character.h

diff --git a/third_party/WebKit/Source/platform/fonts/Character.h b/third_party/WebKit/Source/platform/fonts/Character.h

index c1f34707709e63358d7d20382e4171c6da3cbf41..50ae75d54ec2da7a0b71fbbd00e8c9fc7275bfd8 100644

--- a/third_party/WebKit/Source/platform/fonts/Character.h

+++ b/third_party/WebKit/Source/platform/fonts/Character.h

@@ -61,7 +61,6 @@ public:

|| isInRange(character, 0xE0100, 0xE01EF); // VARIATION SELECTOR-17 to 256

}

- static bool isCJKIdeograph(UChar32);

static bool isCJKIdeographOrSymbol(UChar32);

static unsigned expansionOpportunityCount(const LChar*, size_t length, TextDirection, bool& isAfterExpansion, const TextJustify);

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/Character.cpp » ('j') | third_party/WebKit/Source/platform/fonts/Character.cpp » ('J')