Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: media/base/bitstream_buffer.cc

Issue 1541353002: Add offset support to BitstreamBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase over crrev.com/1645873002 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/bitstream_buffer.cc
diff --git a/media/base/bitstream_buffer.cc b/media/base/bitstream_buffer.cc
index 9966aaca6baf028d335af7b6a0b11f59c1c59f2b..128c95dd67eb3d087b97e3a14d4105f048de0e9d 100644
--- a/media/base/bitstream_buffer.cc
+++ b/media/base/bitstream_buffer.cc
@@ -7,23 +7,17 @@
namespace media {
BitstreamBuffer::BitstreamBuffer()
- : id_(-1), size_(0), presentation_timestamp_(kNoTimestamp()) {}
-
-BitstreamBuffer::BitstreamBuffer(int32_t id,
- base::SharedMemoryHandle handle,
- size_t size)
- : id_(id),
- handle_(handle),
- size_(size),
- presentation_timestamp_(kNoTimestamp()) {}
+ : BitstreamBuffer(-1, base::SharedMemoryHandle(), 0, 0, kNoTimestamp()) {}
dcheng 2016/03/01 01:48:43 Since you have default args on the constructor...
Owen Lin 2016/03/02 02:50:53 Done.
BitstreamBuffer::BitstreamBuffer(int32_t id,
base::SharedMemoryHandle handle,
size_t size,
+ off_t offset,
base::TimeDelta presentation_timestamp)
: id_(id),
handle_(handle),
size_(size),
+ offset_(offset),
presentation_timestamp_(presentation_timestamp) {}
BitstreamBuffer::~BitstreamBuffer() {}

Powered by Google App Engine
This is Rietveld 408576698