Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 154133003: IDL compiler: sync Python to r166698 (and add test case) (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: sync Python to r166698 (and add test case) Python side to: Move encryptedmedia module to oilpan https://codereview.chromium.org/139173012 BUG=239771 TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M Source/bindings/templates/interface.h View 1 chunk +9 lines, -5 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceWillBeGarbageCollected.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 2 chunks +7 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-10 07:13:45 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-10 07:14:14 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-10 09:16:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/154133003/1
6 years, 10 months ago (2014-02-10 09:17:07 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 09:17:24 UTC) #5
Message was sent while issue was closed.
Change committed as 166812

Powered by Google App Engine
This is Rietveld 408576698