Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1541323004: Revert of remoting: use VerifyHostPinHash() in place on IsPinValid() (Closed)

Created:
4 years, 12 months ago by Łukasz Anforowicz
Modified:
4 years, 12 months ago
Reviewers:
Sergey Ulanov, tfarina
CC:
chromium-reviews, chromoting-reviews_chromium.org, Lambros, Mark Mentovai, Jamie, Wez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of remoting: use VerifyHostPinHash() in place on IsPinValid() (patchset #6 id:100001 of https://codereview.chromium.org/1547533002/ ) Reason for revert: Relanding still broke the build - https://build.chromium.org/p/chromium/builders/Mac/builds/10279/steps/compile/logs/stdio: Undefined symbols for architecture i386: "remoting::kHostConfigFileName", referenced from: -[Me2MePreferencePane readNewConfig] in remoting_host_prefpane.me2me_preference_pane.i386.o -[Me2MePreferencePane mismatchAlertDidEnd:returnCode:contextInfo:] in remoting_host_prefpane.me2me_preference_pane.i386.o Original issue's description: > remoting: use VerifyHostPinHash() in place on IsPinValid() > > For over a year, we have been shipping a 64-bit version of Chrome for Mac. > So with this statement, this patch makes the switch to > VerifyHostPinHash() function from remoting/host/pin_hash.h, fixing the > lambroslambrou's TODO. > > BUG=None > R=sergeyu@chromium.org > > Committed: https://crrev.com/7acd392e4018d121977e2738b6e3c59f5cf418f1 > Cr-Commit-Position: refs/heads/master@{#366762} > > Committed: https://crrev.com/d433493df4b98ea006e6407590cff7a7912e16df > Cr-Commit-Position: refs/heads/master@{#366783} TBR=sergeyu@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/0750b7fc18b8b510f8763164fb8661c2ba6eee94 Cr-Commit-Position: refs/heads/master@{#366790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M remoting/host/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/mac/me2me_preference_pane.mm View 3 chunks +47 lines, -2 lines 0 comments Download
M remoting/remoting_host_mac.gypi View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Łukasz Anforowicz
Created Revert of remoting: use VerifyHostPinHash() in place on IsPinValid()
4 years, 12 months ago (2015-12-24 02:04:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541323004/1
4 years, 12 months ago (2015-12-24 02:05:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-24 02:05:38 UTC) #4
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 02:07:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0750b7fc18b8b510f8763164fb8661c2ba6eee94
Cr-Commit-Position: refs/heads/master@{#366790}

Powered by Google App Engine
This is Rietveld 408576698