Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1541323003: Add extra_data_field_ in gpu::SyncToken converter and remove two array converters (Closed)

Created:
5 years ago by Peng
Modified:
5 years ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add extra_data_field_ in gpu::SyncToken converter and remove two array converters BUG=565553 TBR=ben@chromium.org Committed: https://crrev.com/090488ff3ff55782b02a1b2965bdbe2acd0b8f53 Cr-Commit-Position: refs/heads/master@{#366758}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -76 lines) Patch
M components/mus/public/interfaces/compositor_frame.mojom View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.h View 2 chunks +0 lines, -30 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 4 chunks +2 lines, -46 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Peng
Hi Fady, PTAL. Thanks.
5 years ago (2015-12-23 17:07:42 UTC) #2
Fady Samuel
Could you please give some more background? What's this extra field for?
5 years ago (2015-12-23 17:13:02 UTC) #3
Peng
On 2015/12/23 17:13:02, Fady Samuel wrote: > Could you please give some more background? What's ...
5 years ago (2015-12-23 17:16:04 UTC) #5
Peng
On 2015/12/23 17:13:02, Fady Samuel wrote: > Could you please give some more background? What's ...
5 years ago (2015-12-23 17:16:06 UTC) #6
Fady Samuel
lgtm
5 years ago (2015-12-23 17:33:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541323003/20001
5 years ago (2015-12-23 17:34:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131403)
5 years ago (2015-12-23 17:41:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541323003/20001
5 years ago (2015-12-23 18:35:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-23 18:39:13 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-23 18:40:07 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/090488ff3ff55782b02a1b2965bdbe2acd0b8f53
Cr-Commit-Position: refs/heads/master@{#366758}

Powered by Google App Engine
This is Rietveld 408576698