Remove ANGLE_pack_reverse_row_order.

gpu/command_buffer/client/gles2_implementation.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A class to emulate GLES2 over command buffers.
 
 #include "gpu/command_buffer/client/gles2_implementation.h"
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
@@ skipping 66 matching lines @@
 GLES2Implementation::GLES2Implementation(
     GLES2CmdHelper* helper,
     ShareGroup* share_group,
     TransferBufferInterface* transfer_buffer,
     bool bind_generates_resource,
     bool lose_context_when_out_of_memory,
     bool support_client_side_arrays,
     GpuControl* gpu_control)
     : helper_(helper),
       transfer_buffer_(transfer_buffer),
-      angle_pack_reverse_row_order_status_(kUnknownExtensionStatus),
       chromium_framebuffer_multisample_(kUnknownExtensionStatus),
       pack_alignment_(4),
       pack_row_length_(0),
       pack_skip_pixels_(0),
       pack_skip_rows_(0),
       unpack_alignment_(4),
       unpack_row_length_(0),
       unpack_image_height_(0),
       unpack_skip_rows_(0),
       unpack_skip_pixels_(0),
       unpack_skip_images_(0),
-      pack_reverse_row_order_(false),
       active_texture_unit_(0),
       bound_framebuffer_(0),
       bound_read_framebuffer_(0),
       bound_renderbuffer_(0),
       bound_valuebuffer_(0),
       current_program_(0),
       bound_array_buffer_(0),
       bound_copy_read_buffer_(0),
       bound_copy_write_buffer_(0),
       bound_pixel_pack_buffer_(0),
@@ skipping 328 matching lines @@
       return false;
     default: {
       bool available = IsExtensionAvailable(extension);
       *status = available ? kAvailableExtensionStatus :
                             kUnavailableExtensionStatus;
       return available;
     }
   }
 }
 
-bool GLES2Implementation::IsAnglePackReverseRowOrderAvailable() {
-  return IsExtensionAvailableHelper(
-      "GL_ANGLE_pack_reverse_row_order",
-      &angle_pack_reverse_row_order_status_);
-}
-
 bool GLES2Implementation::IsChromiumFramebufferMultisampleAvailable() {
   return IsExtensionAvailableHelper(
       "GL_CHROMIUM_framebuffer_multisample",
       &chromium_framebuffer_multisample_);
 }
 
 const std::string& GLES2Implementation::GetLogPrefix() const {
   const std::string& prefix(debug_marker_manager_.GetMarker());
   return prefix.empty() ? this_in_hex_ : prefix;
 }
@@ skipping 1337 matching lines @@
       break;
     case GL_UNPACK_SKIP_ROWS_EXT:
       unpack_skip_rows_ = param;
       break;
     case GL_UNPACK_SKIP_PIXELS_EXT:
       unpack_skip_pixels_ = param;
       break;
     case GL_UNPACK_SKIP_IMAGES:
       unpack_skip_images_ = param;
       break;
-    case GL_PACK_REVERSE_ROW_ORDER_ANGLE:
-      pack_reverse_row_order_ =
-          IsAnglePackReverseRowOrderAvailable() ? (param != 0) : false;
-      break;
     default:
       break;
   }
   helper_->PixelStorei(pname, param);
   CheckGLError();
 }
 
 void GLES2Implementation::VertexAttribIPointer(
     GLuint index, GLint size, GLenum type, GLsizei stride, const void* ptr) {
   GPU_CLIENT_SINGLE_THREAD_CHECK();
@@ skipping 1805 matching lines @@
       return;
     }
     *result = 0;  // mark as failed.
     helper_->ReadPixels(
         xoffset, yoffset, width, num_rows, format, type,
         buffer.shm_id(), buffer.offset(),
         GetResultShmId(), GetResultShmOffset(),
         false);
     WaitForCmd();
     if (*result != 0) {
-      // when doing a y-flip we have to iterate through top-to-bottom chunks
-      // of the dst. The service side handles reversing the rows within a
-      // chunk.
-      int8_t* rows_dst;
-      if (pack_reverse_row_order_) {
-          rows_dst = dest + (height - num_rows) * dst_padded_row_size;
-      } else {
-          rows_dst = dest;
-      }
       // We have to copy 1 row at a time to avoid writing pad bytes.
       const int8_t* src = static_cast<const int8_t*>(buffer.address());
       for (GLint yy = 0; yy < num_rows; ++yy) {
-        memcpy(rows_dst, src, unpadded_row_size);
-        rows_dst += dst_padded_row_size;
+        memcpy(dest, src, unpadded_row_size);
+        dest += dst_padded_row_size;
         src += padded_row_size;
       }
-      if (!pack_reverse_row_order_) {
-        dest = rows_dst;
-      }
     }
     // If it was not marked as successful exit.
     if (*result == 0) {
       return;
     }
     yoffset += num_rows;
     height -= num_rows;
   }
   CheckGLError();
 }
@@ skipping 1160 matching lines @@
   SetBucketAsCString(kResultBucketId, extension);
   helper_->RequestExtensionCHROMIUM(kResultBucketId);
   helper_->SetBucketSize(kResultBucketId, 0);
 
   struct ExtensionCheck {
     const char* extension;
     ExtensionStatus* status;
   };
   const ExtensionCheck checks[] = {
     {
-      "GL_ANGLE_pack_reverse_row_order",
-      &angle_pack_reverse_row_order_status_,
-    },
-    {
       "GL_CHROMIUM_framebuffer_multisample",
        &chromium_framebuffer_multisample_,
     },
   };
   const size_t kNumChecks = sizeof(checks)/sizeof(checks[0]);
   for (size_t ii = 0; ii < kNumChecks; ++ii) {
     const ExtensionCheck& check = checks[ii];
     if (*check.status == kUnavailableExtensionStatus &&
         !strcmp(extension, check.extension)) {
       *check.status = kUnknownExtensionStatus;
@@ skipping 1716 matching lines @@
   CheckGLError();
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/client/gles2_implementation_impl_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu