Landing Recent QUIC changes until 12/18/2015 13:57 UTC

Landing Recent QUIC changes until 12/18/2015 13:57 UTC

relnote: Replace last remaining NULLs in gfe/quic with nullptr. No behavior change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

relnote: Add PushResponse() in QuicSimpleServerStream.

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

relnote: Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes when logging them server side.  We can always add more details where useful at a later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

relnote: Add path_id to QuicSentPacketManager and QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

relnote: Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

relnote: If the user supplied a request body in hex, print response body in hex as well. In addition, convert hex in both cases to printable ASCII characters where possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

relnote: Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

relnote: Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

relnote: Drop packets which are larger than kMaxPacketSize, instead of closing the connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

relnote: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not empty. An empty host works fine in google3, but breaks tests in Chromium for $reasons.

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

relnote: Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

relnote: If message body specified with --body_hex then print out the user provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org

Committed: https://crrev.com/a31a74b13ef5d8c7252138f147a5716c9682cab7
Cr-Commit-Position: refs/heads/master@{#366986}

[Fan Yang, 2015-12-22 23:23:51]

Description was changed from

==========
Replace last remaining NULLs in gfe/quic with nullptr. No behavior change.

Merge internal change: 110570650

Add PushResponse() in QuicSimpleServerStream.

n/a (QUIC toy server)

Merge internal change: 110554875

Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286

Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464

Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683

If the user supplied a request body in hex, print response body in hex as well.
In addition, convert hex in both cases to printable ASCII characters where
possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

n/a (QUIC client)

Merge internal change: 110446931

Drop not awaited packets before decrypt them.

Merge internal change: 110403572

Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215

Drop packets which are larger than kMaxPacketSize, instead of closing the
connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154

Merge branch '110267778' into 110286048


Merge branch '110244865' into 110254138


change


Thanks, Ryan. PTAL.


dds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not
empty. An empty host works fine in google3, but breaks tests in Chromium for
$reasons.

n/a (QUIC test only)

Merge internal change: 110286048

Delete unused methods in QuicServerSession

Merge internal change: 110254138

n/a (quic toy client)

If message body specified with --body_hex then print out the user provided
string rather than the binary body.

Merge internal change: 110244865

R=rch@chromium.org
BUG=
==========

to

==========
Replace last remaining NULLs in gfe/quic with nullptr. No behavior change.

Merge internal change: 110570650

Add PushResponse() in QuicSimpleServerStream.

n/a (QUIC toy server)

Merge internal change: 110554875

Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286

Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464

Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683

If the user supplied a request body in hex, print response body in hex as well.
In addition, convert hex in both cases to printable ASCII characters where
possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

n/a (QUIC client)

Merge internal change: 110446931

Drop not awaited packets before decrypt them.

Merge internal change: 110403572

Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215

Drop packets which are larger than kMaxPacketSize, instead of closing the
connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154


Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not
empty. An empty host works fine in google3, but breaks tests in Chromium for
$reasons.

n/a (QUIC test only)

Merge internal change: 110286048

Delete unused methods in QuicServerSession

Merge internal change: 110254138

n/a (quic toy client)

If message body specified with --body_hex then print out the user provided
string rather than the binary body.

Merge internal change: 110244865

R=rch@chromium.org
==========

[Fan Yang, 2015-12-22 23:53:52]

Patchset #1 (id:1) has been deleted

[Fan Yang, 2015-12-23 00:02:06]

Description was changed from

==========
Replace last remaining NULLs in gfe/quic with nullptr. No behavior change.

Merge internal change: 110570650

Add PushResponse() in QuicSimpleServerStream.

n/a (QUIC toy server)

Merge internal change: 110554875

Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286

Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464

Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683

If the user supplied a request body in hex, print response body in hex as well.
In addition, convert hex in both cases to printable ASCII characters where
possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

n/a (QUIC client)

Merge internal change: 110446931

Drop not awaited packets before decrypt them.

Merge internal change: 110403572

Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215

Drop packets which are larger than kMaxPacketSize, instead of closing the
connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154


Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not
empty. An empty host works fine in google3, but breaks tests in Chromium for
$reasons.

n/a (QUIC test only)

Merge internal change: 110286048

Delete unused methods in QuicServerSession

Merge internal change: 110254138

n/a (quic toy client)

If message body specified with --body_hex then print out the user provided
string rather than the binary body.

Merge internal change: 110244865

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 12/18/2015 13:57 UTC

Replace last remaining NULLs in gfe/quic with nullptr. No behavior change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

Add PushResponse() in QuicSimpleServerStream.

n/a (QUIC toy server)

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

If the user supplied a request body in hex, print response body in hex as well.
In addition, convert hex in both cases to printable ASCII characters where
possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

n/a (QUIC client)

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

Drop packets which are larger than kMaxPacketSize, instead of closing the
connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not
empty. An empty host works fine in google3, but breaks tests in Chromium for
$reasons.

n/a (QUIC test only)

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

n/a (quic toy client)

If message body specified with --body_hex then print out the user provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org
==========

[Fan Yang, 2015-12-23 00:04:58]

Description was changed from

==========
Landing Recent QUIC changes until 12/18/2015 13:57 UTC

Replace last remaining NULLs in gfe/quic with nullptr. No behavior change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

Add PushResponse() in QuicSimpleServerStream.

n/a (QUIC toy server)

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

If the user supplied a request body in hex, print response body in hex as well.
In addition, convert hex in both cases to printable ASCII characters where
possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

n/a (QUIC client)

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

Drop packets which are larger than kMaxPacketSize, instead of closing the
connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not
empty. An empty host works fine in google3, but breaks tests in Chromium for
$reasons.

n/a (QUIC test only)

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

n/a (quic toy client)

If message body specified with --body_hex then print out the user provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 12/18/2015 13:57 UTC

relnote: Replace last remaining NULLs in gfe/quic with nullptr. No behavior
change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

relnote: Add PushResponse() in QuicSimpleServerStream.

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

relnote: Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

relnote: Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

relnote: Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

relnote: If the user supplied a request body in hex, print response body in hex
as well. In addition, convert hex in both cases to printable ASCII characters
where possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

relnote: Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

relnote: Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

relnote: Drop packets which are larger than kMaxPacketSize, instead of closing
the connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

relnote: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse
is not empty. An empty host works fine in google3, but breaks tests in Chromium
for $reasons.

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

relnote: Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

relnote: If message body specified with --body_hex then print out the user
provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org
==========

[Ryan Hamilton, 2015-12-23 00:19:35]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-12-23 00:19:36]

lgtm

[commit-bot: I haz the power, 2015-12-23 00:20:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541263002/20001

[commit-bot: I haz the power, 2015-12-23 00:27:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-23 00:27:02]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Fan Yang, 2015-12-23 00:57:38]

The CQ bit was checked by fayang@chromium.org

[Fan Yang, 2015-12-23 00:57:38]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1541263002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-12-23 00:57:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541263002/60001

[commit-bot: I haz the power, 2015-12-23 01:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-23 01:06:34]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Fan Yang, 2015-12-23 01:24:53]

The CQ bit was checked by fayang@chromium.org

[Fan Yang, 2015-12-23 01:24:54]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1541263002/#ps80001
(title: "fix unsigned long")

[commit-bot: I haz the power, 2015-12-23 01:25:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541263002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541263002/80001

[commit-bot: I haz the power, 2015-12-23 01:33:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-23 01:33:28]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Fan Yang, 2015-12-23 01:58:52]

The CQ bit was checked by fayang@chromium.org

[Fan Yang, 2015-12-23 01:58:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1541263002/#ps100001
(title: "use static_cast<size_t>")

[commit-bot: I haz the power, 2015-12-23 01:59:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541263002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541263002/100001

[commit-bot: I haz the power, 2015-12-23 02:08:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-23 02:08:18]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Fan Yang, 2015-12-23 02:24:44]

The CQ bit was checked by fayang@chromium.org

[Fan Yang, 2015-12-23 02:24:45]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1541263002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-12-23 02:25:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541263002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541263002/120001

[commit-bot: I haz the power, 2015-12-23 02:47:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-23 02:47:30]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Fan Yang, 2015-12-23 19:08:46]

The CQ bit was checked by fayang@chromium.org

[Fan Yang, 2015-12-23 19:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1541263002/#ps140001
(title: "rebase again.")

[commit-bot: I haz the power, 2015-12-23 19:09:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541263002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541263002/140001

[commit-bot: I haz the power, 2015-12-23 19:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-23 19:35:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fan Yang, 2015-12-28 16:02:37]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-28 16:03:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541263002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541263002/200001

[commit-bot: I haz the power, 2015-12-28 17:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-28 17:21:49]

Dry run: This issue passed the CQ dry run.

[Fan Yang, 2015-12-28 17:21:57]

The CQ bit was checked by fayang@chromium.org

[Fan Yang, 2015-12-28 17:21:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1541263002/#ps200001
(title: "replace -1 with 0xff for InvalidPathId")

[commit-bot: I haz the power, 2015-12-28 17:22:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541263002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541263002/200001

[commit-bot: I haz the power, 2015-12-28 17:27:21]

Description was changed from

==========
Landing Recent QUIC changes until 12/18/2015 13:57 UTC

relnote: Replace last remaining NULLs in gfe/quic with nullptr. No behavior
change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

relnote: Add PushResponse() in QuicSimpleServerStream.

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

relnote: Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

relnote: Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

relnote: Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

relnote: If the user supplied a request body in hex, print response body in hex
as well. In addition, convert hex in both cases to printable ASCII characters
where possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

relnote: Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

relnote: Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

relnote: Drop packets which are larger than kMaxPacketSize, instead of closing
the connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

relnote: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse
is not empty. An empty host works fine in google3, but breaks tests in Chromium
for $reasons.

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

relnote: Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

relnote: If message body specified with --body_hex then print out the user
provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 12/18/2015 13:57 UTC

relnote: Replace last remaining NULLs in gfe/quic with nullptr. No behavior
change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

relnote: Add PushResponse() in QuicSimpleServerStream.

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

relnote: Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

relnote: Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

relnote: Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

relnote: If the user supplied a request body in hex, print response body in hex
as well. In addition, convert hex in both cases to printable ASCII characters
where possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

relnote: Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

relnote: Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

relnote: Drop packets which are larger than kMaxPacketSize, instead of closing
the connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

relnote: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse
is not empty. An empty host works fine in google3, but breaks tests in Chromium
for $reasons.

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

relnote: Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

relnote: If message body specified with --body_hex then print out the user
provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org
==========

[commit-bot: I haz the power, 2015-12-28 17:27:23]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2015-12-28 17:28:40]

Description was changed from

==========
Landing Recent QUIC changes until 12/18/2015 13:57 UTC

relnote: Replace last remaining NULLs in gfe/quic with nullptr. No behavior
change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

relnote: Add PushResponse() in QuicSimpleServerStream.

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

relnote: Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

relnote: Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

relnote: Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

relnote: If the user supplied a request body in hex, print response body in hex
as well. In addition, convert hex in both cases to printable ASCII characters
where possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

relnote: Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

relnote: Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

relnote: Drop packets which are larger than kMaxPacketSize, instead of closing
the connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

relnote: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse
is not empty. An empty host works fine in google3, but breaks tests in Chromium
for $reasons.

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

relnote: Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

relnote: If message body specified with --body_hex then print out the user
provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 12/18/2015 13:57 UTC

relnote: Replace last remaining NULLs in gfe/quic with nullptr. No behavior
change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

relnote: Add PushResponse() in QuicSimpleServerStream.

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

relnote: Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes
when logging them server side.  We can always add more details where useful at a
later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

relnote: Add path_id to QuicSentPacketManager and
QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

relnote: Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

relnote: If the user supplied a request body in hex, print response body in hex
as well. In addition, convert hex in both cases to printable ASCII characters
where possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

relnote: Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

relnote: Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

relnote: Drop packets which are larger than kMaxPacketSize, instead of closing
the connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

relnote: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse
is not empty. An empty host works fine in google3, but breaks tests in Chromium
for $reasons.

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

relnote: Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

relnote: If message body specified with --body_hex then print out the user
provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org

Committed: https://crrev.com/a31a74b13ef5d8c7252138f147a5716c9682cab7
Cr-Commit-Position: refs/heads/master@{#366986}
==========

[commit-bot: I haz the power, 2015-12-28 17:28:41]

Patchset 10 (id:??) landed as
https://crrev.com/a31a74b13ef5d8c7252138f147a5716c9682cab7
Cr-Commit-Position: refs/heads/master@{#366986}