Force locale to C to allow recognizing output from subprocesses in adb_gdb

Force locale to C to allow recognizing output from subprocesses in adb_gdb

adb_gdb uses console output for matching running process. In systems with locale
other than EN, the matching will be failed, set the locale to C to fix this.

BUG=

Committed: https://crrev.com/353749a23e10d0a4ff4d4529b9859e31c891c788
Cr-Commit-Position: refs/heads/master@{#366864}

[Shouqun1, 2015-12-23 13:36:20]

liushouqun@xiaomi.com changed reviewers:
+ pasko@chromium.org

[Shouqun1, 2015-12-23 13:36:20]

Hi pasko@, PTAL, thanks!

[pasko, 2015-12-23 14:05:31]

good idea, only suggesting a change in the comment

https://codereview.chromium.org/1541243003/diff/1/build/android/adb_gdb
File build/android/adb_gdb (right):

https://codereview.chromium.org/1541243003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:18: # Set the locale to force using default language.
Using the word "default" is confusing in this context because the standard says:
"Some implementations may provide facilities for local installation
administrators to set the default locale, customizing it for each location."

In other words, the C locale (POSIX locale) is not necessarily the default on
the machine.

I would suggest to say: "Force locale to C to allow recognizing output from
subprocesses."

[Shouqun1, 2015-12-24 01:03:10]

Description was changed from

==========
Set the locale to default language in adb_gdb

adb_gdb uses console output for matching running process. In systems with locale
other than EN, the matching will be failed, set the locale to default to fix
this.

BUG=
==========

to

==========
Force locale to C to allow recognizing output from subprocesses in adb_gdb

adb_gdb uses console output for matching running process. In systems with locale
other than EN, the matching will be failed, set the locale to C to fix this.

BUG=
==========

[Shouqun1, 2015-12-24 01:04:58]

comment updated, thanks!

https://codereview.chromium.org/1541243003/diff/1/build/android/adb_gdb
File build/android/adb_gdb (right):

https://codereview.chromium.org/1541243003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:18: # Set the locale to force using default language.
On 2015/12/23 14:05:31, pasko wrote:
> Using the word "default" is confusing in this context because the standard
says:
> "Some implementations may provide facilities for local installation
> administrators to set the default locale, customizing it for each location."
> 
> In other words, the C locale (POSIX locale) is not necessarily the default on
> the machine.
> 
> I would suggest to say: "Force locale to C to allow recognizing output from
> subprocesses."

Done.

[pasko, 2015-12-25 11:25:19]

lgtm

[Shouqun1, 2015-12-25 14:56:37]

The CQ bit was checked by liushouqun@xiaomi.com

[commit-bot: I haz the power, 2015-12-25 14:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541243003/20001

[commit-bot: I haz the power, 2015-12-25 15:15:29]

Description was changed from

==========
Force locale to C to allow recognizing output from subprocesses in adb_gdb

adb_gdb uses console output for matching running process. In systems with locale
other than EN, the matching will be failed, set the locale to C to fix this.

BUG=
==========

to

==========
Force locale to C to allow recognizing output from subprocesses in adb_gdb

adb_gdb uses console output for matching running process. In systems with locale
other than EN, the matching will be failed, set the locale to C to fix this.

BUG=
==========

[commit-bot: I haz the power, 2015-12-25 15:15:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-25 15:16:44]

Description was changed from

==========
Force locale to C to allow recognizing output from subprocesses in adb_gdb

adb_gdb uses console output for matching running process. In systems with locale
other than EN, the matching will be failed, set the locale to C to fix this.

BUG=
==========

to

==========
Force locale to C to allow recognizing output from subprocesses in adb_gdb

adb_gdb uses console output for matching running process. In systems with locale
other than EN, the matching will be failed, set the locale to C to fix this.

BUG=

Committed: https://crrev.com/353749a23e10d0a4ff4d4529b9859e31c891c788
Cr-Commit-Position: refs/heads/master@{#366864}
==========

[commit-bot: I haz the power, 2015-12-25 15:16:45]

Patchset 2 (id:??) landed as
https://crrev.com/353749a23e10d0a4ff4d4529b9859e31c891c788
Cr-Commit-Position: refs/heads/master@{#366864}