Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: net/data/parse_ocsp_unittest/annotate_test_data.py

Issue 1541213002: Adding OCSP Parser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving Verify to end. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/data/parse_ocsp_unittest/annotate_test_data.py
diff --git a/net/data/verify_signed_data_unittest/annotate_test_data.py b/net/data/parse_ocsp_unittest/annotate_test_data.py
similarity index 90%
copy from net/data/verify_signed_data_unittest/annotate_test_data.py
copy to net/data/parse_ocsp_unittest/annotate_test_data.py
index 733392ee060e6b9c7e8c12279977566914f632fe..d00ca4ab2e76f529659c9983ed3a95e0da6b6aae 100755
--- a/net/data/verify_signed_data_unittest/annotate_test_data.py
+++ b/net/data/parse_ocsp_unittest/annotate_test_data.py
@@ -57,6 +57,17 @@ def GenerateCommentForBlock(block_name, block_data):
stdout_data, stderr_data = p.communicate(input=block_data)
generated_comment = '$ openssl asn1parse -i < [%s]\n%s' % (block_name,
stdout_data)
+
+ if block_name == 'OCSP RESPONSE':
eroman 2016/02/16 23:42:26 Add a comment explaining this.
svaldez 2016/02/17 16:46:47 Done.
+ if '[HEX DUMP]:' in generated_comment:
+ (generated_comment, response) = generated_comment.split('[HEX DUMP]:', 1)
eroman 2016/02/16 23:42:26 I recall encountering a bug with OpenSSL's hex dum
svaldez 2016/02/17 16:46:47 Acknowledged.
+ response = response.replace('\n', '')
+ if len(response) % 2 != 0:
+ response = '0' + response
+ response = GenerateCommentForBlock('INNER', response.decode('hex'))
+ response = response.split('\n', 1)[1]
+ response = response.replace(': ', ': ')
+ generated_comment += '\n%s' % (response)
return generated_comment.strip('\n')

Powered by Google App Engine
This is Rietveld 408576698