IPC-based sync compositor software draw optimization

content/browser/android/synchronous_compositor_host.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/synchronous_compositor_host.h"
 
 #include "base/containers/hash_tables.h"
 #include "base/memory/shared_memory.h"
 #include "base/trace_event/trace_event_argument.h"
 #include "cc/output/compositor_frame_ack.h"
@@ skipping 78 matching lines @@
   if (frame)
     UpdateFrameMetaData(frame->metadata);
   return frame;
 }
 
 void SynchronousCompositorHost::UpdateFrameMetaData(
     const cc::CompositorFrameMetadata& frame_metadata) {
   rwhva_->SynchronousFrameMetadata(frame_metadata);
 }
 
+class SynchronousCompositorHost::ScopedSendZeroMemory {
+ public:
+  ScopedSendZeroMemory(SynchronousCompositorHost* host) : host_(host) {}
+  ~ScopedSendZeroMemory() { host_->SendZeroMemory(); }
+
+ private:
+  SynchronousCompositorHost* host_;

[dcheng, 2015/12/29 00:00:24]

Nit: T* const.

[boliu, 2015/12/29 00:16:30]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(ScopedSendZeroMemory);
+};
+
+struct SynchronousCompositorHost::SharedMemoryWithSize {
+  base::SharedMemory shm;
+  const size_t stride;
+  const size_t buffer_size;
+
+  SharedMemoryWithSize(size_t stride, size_t buffer_size)
+      : stride(stride), buffer_size(buffer_size) {}
+};

[dcheng, 2015/12/29 00:00:24]

DISALLOW_COPY_AND_ASSIGN here too?

[boliu, 2015/12/29 00:16:30]

Done.

+
 bool SynchronousCompositorHost::DemandDrawSw(SkCanvas* canvas) {
   SyncCompositorDemandDrawSwParams params;
   params.size = gfx::Size(canvas->getBaseLayerSize().width(),
                           canvas->getBaseLayerSize().height());
   SkIRect canvas_clip;
   canvas->getClipDeviceBounds(&canvas_clip);
   params.clip = gfx::SkIRectToRect(canvas_clip);
   params.transform.matrix() = canvas->getTotalMatrix();
   if (params.size.IsEmpty())
     return true;
 
   SkImageInfo info =
       SkImageInfo::MakeN32Premul(params.size.width(), params.size.height());
   DCHECK_EQ(kRGBA_8888_SkColorType, info.colorType());
   size_t stride = info.minRowBytes();
   size_t buffer_size = info.getSafeSize(stride);
   if (!buffer_size)
     return false;  // Overflow.
 
-  base::SharedMemory shm;
-  {
-    TRACE_EVENT1("browser", "AllocateSharedMemory", "buffer_size", buffer_size);
-    if (!shm.CreateAndMapAnonymous(buffer_size))
-      return false;
-  }
-  base::ProcessHandle renderer_process_handle =
-      rwhva_->GetRenderWidgetHost()->GetProcess()->GetHandle();
-  if (!shm.ShareToProcess(renderer_process_handle, &params.shm_handle))
+  SetSoftwareDrawSharedMemoryIfNeeded(stride, buffer_size);
+  if (!software_draw_shm_)
     return false;
 
   scoped_ptr<cc::CompositorFrame> frame(new cc::CompositorFrame);
   SyncCompositorCommonBrowserParams common_browser_params;
   PopulateCommonParams(&common_browser_params);
   SyncCompositorCommonRendererParams common_renderer_params;
   bool success = false;
   if (!sender_->Send(new SyncCompositorMsg_DemandDrawSw(
           routing_id_, common_browser_params, params, &success,
           &common_renderer_params, frame.get()))) {
     return false;
   }
+  ScopedSendZeroMemory send_zero_memory(this);
   if (!success)
     return false;
 
   ProcessCommonParams(common_renderer_params);
   UpdateFrameMetaData(frame->metadata);
 
   SkBitmap bitmap;
-  if (!bitmap.installPixels(info, shm.memory(), stride))
+  if (!bitmap.installPixels(info, software_draw_shm_->shm.memory(), stride))
     return false;
 
   {
     TRACE_EVENT0("browser", "DrawBitmap");
     canvas->save();
     canvas->resetMatrix();
     canvas->drawBitmap(bitmap, 0, 0);
     canvas->restore();
   }
 
   return true;
 }
 
+void SynchronousCompositorHost::SetSoftwareDrawSharedMemoryIfNeeded(
+    size_t stride,
+    size_t buffer_size) {
+  if (software_draw_shm_ && software_draw_shm_->stride == stride &&
+      software_draw_shm_->buffer_size == buffer_size)
+    return;
+  software_draw_shm_.reset();
+  scoped_ptr<SharedMemoryWithSize> software_draw_shm(
+      new SharedMemoryWithSize(stride, buffer_size));
+  {
+    TRACE_EVENT1("browser", "AllocateSharedMemory", "buffer_size", buffer_size);
+    if (!software_draw_shm->shm.CreateAndMapAnonymous(buffer_size))
+      return;
+  }
+
+  SyncCompositorSetSharedMemoryParams set_shm_params;
+  set_shm_params.buffer_size = buffer_size;
+  base::ProcessHandle renderer_process_handle =
+      rwhva_->GetRenderWidgetHost()->GetProcess()->GetHandle();
+  if (!software_draw_shm->shm.ShareToProcess(renderer_process_handle,
+                                             &set_shm_params.shm_handle)) {
+    return;
+  }
+
+  SyncCompositorCommonBrowserParams common_browser_params;
+  PopulateCommonParams(&common_browser_params);
+  bool success = false;
+  SyncCompositorCommonRendererParams common_renderer_params;
+  if (!sender_->Send(new SyncCompositorMsg_SetSharedMemory(
+          routing_id_, common_browser_params, set_shm_params, &success,
+          &common_renderer_params)) ||
+      !success) {
+    return;
+  }
+  software_draw_shm_ = std::move(software_draw_shm);

[dcheng, 2015/12/29 00:00:24]

#include <utility>

[boliu, 2015/12/29 00:16:30]

Done.

+  ProcessCommonParams(common_renderer_params);
+}
+
+void SynchronousCompositorHost::SendZeroMemory() {
+  // No need to check return value.
+  sender_->Send(new SyncCompositorMsg_ZeroSharedMemory(routing_id_));
+}
+
 void SynchronousCompositorHost::ReturnResources(
     const cc::CompositorFrameAck& frame_ack) {
   returned_resources_.insert(returned_resources_.end(),
                              frame_ack.resources.begin(),
                              frame_ack.resources.end());
 }
 
 void SynchronousCompositorHost::SetMemoryPolicy(size_t bytes_limit) {
   if (bytes_limit_ == bytes_limit)
     return;
@@ skipping 141 matching lines @@
         params.scrollable_size, params.page_scale_factor,
         params.min_page_scale_factor, params.max_page_scale_factor);
   }
 }
 
 void SynchronousCompositorHost::UpdateNeedsBeginFrames() {
   rwhva_->OnSetNeedsBeginFrames(is_active_ && need_begin_frame_);
 }
 
 }  // namespace content