Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: ui/message_center/BUILD.gn

Issue 1541163002: GN(android) Don't enable --gc-sections in debug mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gn gen Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/runner/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/BUILD.gn
diff --git a/ui/message_center/BUILD.gn b/ui/message_center/BUILD.gn
index de11882a040681a92e26a303d9dea30ad00eb37a..bda992c3c3704e9e1557e8c383ecf5bb84ad3143 100644
--- a/ui/message_center/BUILD.gn
+++ b/ui/message_center/BUILD.gn
@@ -9,31 +9,33 @@ import("//testing/test.gni")
component("message_center") {
deps = [
"//base",
- "//base:i18n",
- "//base/third_party/dynamic_annotations",
- "//components/url_formatter",
- "//skia",
- "//ui/accessibility",
"//ui/base",
- "//ui/events",
- "//ui/gfx",
- "//ui/gfx/geometry",
- "//ui/native_theme",
- "//ui/resources",
- "//ui/strings",
"//url",
]
- configs += [
- "//build/config:precompiled_headers",
-
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- "//build/config/compiler:no_size_t_to_int_warning",
- ]
-
defines = [ "MESSAGE_CENTER_IMPLEMENTATION" ]
if (enable_notifications && !is_android) {
+ deps += [
+ "//base:i18n",
+ "//base/third_party/dynamic_annotations",
+ "//components/url_formatter",
+ "//skia",
+ "//ui/accessibility",
+ "//ui/events",
+ "//ui/gfx",
+ "//ui/gfx/geometry",
+ "//ui/native_theme",
+ "//ui/resources",
+ "//ui/strings",
+ ]
+
+ configs += [
+ "//build/config:precompiled_headers",
+
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ "//build/config/compiler:no_size_t_to_int_warning",
+ ]
sources = [
"cocoa/notification_controller.h",
"cocoa/notification_controller.mm",
@@ -153,28 +155,30 @@ component("message_center") {
}
}
-static_library("test_support") {
+source_set("test_support") {
testonly = true
- sources = [
- "fake_message_center.cc",
- "fake_message_center.h",
- "fake_message_center_tray_delegate.cc",
- "fake_message_center_tray_delegate.h",
- "fake_notifier_settings_provider.cc",
- "fake_notifier_settings_provider.h",
- ]
+
+ if (enable_notifications && !is_android) {
+ sources = [
+ "fake_message_center.cc",
+ "fake_message_center.h",
+ "fake_message_center_tray_delegate.cc",
+ "fake_message_center_tray_delegate.h",
+ "fake_notifier_settings_provider.cc",
+ "fake_notifier_settings_provider.h",
+ ]
+ deps = [
+ "//base",
+ "//base/test:test_support",
+ "//skia",
+ "//ui/gfx",
+ "//ui/gfx/geometry",
+ ]
+ }
public_deps = [
":message_center",
]
-
- deps = [
- "//base",
- "//base/test:test_support",
- "//skia",
- "//ui/gfx",
- "//ui/gfx/geometry",
- ]
}
test("message_center_unittests") {
« no previous file with comments | « mojo/runner/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698