Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1541143003: [Interpreter] Adds support for Load/Store LookupSlots to BytecodeGraphBuilder. (Closed)

Created:
5 years ago by mythria
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Adds support for Load/Store LookupSlots to BytecodeGraphBuilder. Adds support for loads and stores to lookup slots to BytecodeGraphBuilder. Also adds tests for them. BUG=v8:4280 LOG=N Committed: https://crrev.com/d5e849a1dd248580475186ab4498c8e20d0c3dc9 Cr-Commit-Position: refs/heads/master@{#33075}

Patch Set 1 #

Patch Set 2 : removes an extra line in bytecode-graph-builder.h. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -4 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +30 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mythria
Could please take a look. Thanks, Mythri
5 years ago (2015-12-23 12:13:05 UTC) #2
oth
On 2015/12/23 12:13:05, mythria wrote: > Could please take a look. > > Thanks, > ...
5 years ago (2015-12-23 13:44:10 UTC) #3
Benedikt Meurer
LGTM.
4 years, 12 months ago (2015-12-27 07:36:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541143003/20001
4 years, 11 months ago (2016-01-04 09:00:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 09:20:37 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 09:21:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5e849a1dd248580475186ab4498c8e20d0c3dc9
Cr-Commit-Position: refs/heads/master@{#33075}

Powered by Google App Engine
This is Rietveld 408576698