Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: runtime/vm/parser.cc

Issue 1541133003: Incremental changes from background compilation work (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: r Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 15652f065179bea2c29211722b85131919a5af5c..3bea96e69b46bc21a7a002fbed3feb3f26f7fab9 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -12064,8 +12064,10 @@ bool Parser::GetCachedConstant(intptr_t token_pos, Instance* value) {
ConstantsMap constants(isolate()->object_store()->compile_time_constants());
bool is_present = false;
*value ^= constants.GetOrNull(key, &is_present);
- ASSERT(constants.Release().raw() ==
- isolate()->object_store()->compile_time_constants());
+ // Mutator compiler thread may add constants while background compiler
+ // is running , and thus change the value of 'compile_time_constants';
+ // do not assert that 'compile_time_constants' has not changed.
+ constants.Release();
if (FLAG_compiler_stats && is_present) {
isolate_->compiler_stats()->num_const_cache_hits++;
}
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698