Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: runtime/vm/object.cc

Issue 1541133003: Incremental changes from background compilation work (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: r Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index cb3c236ceaed86a1656ef32bd8b97bfafd230697..29a74d5ebccb5df32c58735d0d7745feaafc5e94 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -9591,7 +9591,10 @@ bool Library::LookupResolvedNamesCache(const String& name,
ResolvedNamesMap cache(resolved_names());
bool present = false;
*obj = cache.GetOrNull(name, &present);
- ASSERT(cache.Release().raw() == resolved_names());
+ // Mutator compiler thread may add entries and therefore
+ // change 'resolved_names()' while running a background compilation;
+ // do not ASSERT that 'resolved_names()' has not changed.
+ cache.Release();
return present;
}
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698