Incremental changes from background compilation work

runtime/vm/parser.cc

Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 15652f065179bea2c29211722b85131919a5af5c..3bea96e69b46bc21a7a002fbed3feb3f26f7fab9 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -12064,8 +12064,10 @@ bool Parser::GetCachedConstant(intptr_t token_pos, Instance* value) {
   ConstantsMap constants(isolate()->object_store()->compile_time_constants());
   bool is_present = false;
   *value ^= constants.GetOrNull(key, &is_present);
-  ASSERT(constants.Release().raw() ==
-      isolate()->object_store()->compile_time_constants());
+  // Mutator compiler thread may add constants while background compiler
+  // is running , and thus change the value of 'compile_time_constants';
+  // do not assert that 'compile_time_constants' has not changed.
+  constants.Release();

[siva, 2015/12/22 19:43:47]

Ditto.

[srdjan, 2015/12/22 20:23:10]

Ditto.

   if (FLAG_compiler_stats && is_present) {
     isolate_->compiler_stats()->num_const_cache_hits++;
   }