Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1541133003: Incremental changes from background compilation work (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Adjust comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index 7f4ce9fa0d8d83045a4ccf3b62f2854f57c3a3b7..47697aa76d2af9b97ff5dfc58a185608e062007c 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -276,7 +276,12 @@ bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
}
// Check if getter or setter in function's class and class is currently leaf.
- if (FLAG_guess_icdata_cid &&
+ // Do not run the optimization below if in background compilation since
+ // resolution of getter functions may create new signature classes.
+ // TODO(regis): Remove test for background compilation once signature classes
+ // are not generated any longer.
+ if (Thread::Current()->IsMutatorThread() &&
siva 2015/12/22 19:43:46 if (thread()->IsMutatorThread() &&
srdjan 2015/12/22 20:23:10 Done.
+ FLAG_guess_icdata_cid &&
((call->token_kind() == Token::kGET) ||
(call->token_kind() == Token::kSET))) {
const Class& owner_class = Class::Handle(Z, function().Owner());

Powered by Google App Engine
This is Rietveld 408576698