Incremental changes from background compilation work

Incremental changes from background compilation work

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/6f867815d8cf37196897844405bb86b7b32f42e5

[srdjan, 2015-12-22 19:25:28]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-12-22 19:43:47]

lgtm

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:283: if (Thread::Current()->IsMutatorThread()
&&
if (thread()->IsMutatorThread() &&

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9596: // do not ASSERT that 'resolved_names()' has not
changed.
The background compiler will only add entries and not remove them, maybe there
is a way of asserting that, currently count_ is not exposed by hash map. We
could expose it and store old_count initially and then
add an assert to ensure the count doesn't become less than old_count.

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:12070: constants.Release();
Ditto.

[srdjan, 2015-12-22 20:23:10]

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:283: if (Thread::Current()->IsMutatorThread()
&&
On 2015/12/22 19:43:46, siva wrote:
> if (thread()->IsMutatorThread() &&

Done.

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9596: // do not ASSERT that 'resolved_names()' has not
changed.
On 2015/12/22 19:43:46, siva wrote:
> The background compiler will only add entries and not remove them, maybe there
> is a way of asserting that, currently count_ is not exposed by hash map. We
> could expose it and store old_count initially and then
> add an assert to ensure the count doesn't become less than old_count.

I agreed with you originally, but realized that the count is tied to the local
stack object, not to the array. Not doing anything for the moment.

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1541133003/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:12070: constants.Release();
On 2015/12/22 19:43:47, siva wrote:
> Ditto.

Ditto.

[srdjan, 2015-12-22 20:24:04]

Description was changed from

==========
Incremental changes from background compilation work

BUG=
==========

to

==========
Incremental changes from background compilation work

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6f867815d8cf37196897844405bb86b7b32f42e5
==========

[srdjan, 2015-12-22 20:24:06]

Committed patchset #3 (id:40001) manually as
6f867815d8cf37196897844405bb86b7b32f42e5 (presubmit successful).