Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: src/full-codegen.cc

Issue 154113010: Cleanup: ContextualMode doesn't need to be passed to ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: ports. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/full-codegen.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 436
437 void FullCodeGenerator::PrepareForBailout(Expression* node, State state) { 437 void FullCodeGenerator::PrepareForBailout(Expression* node, State state) {
438 PrepareForBailoutForId(node->id(), state); 438 PrepareForBailoutForId(node->id(), state);
439 } 439 }
440 440
441 441
442 void FullCodeGenerator::CallLoadIC(ContextualMode contextual_mode, 442 void FullCodeGenerator::CallLoadIC(ContextualMode contextual_mode,
443 TypeFeedbackId id) { 443 TypeFeedbackId id) {
444 ExtraICState extra_state = LoadIC::ComputeExtraICState(contextual_mode); 444 ExtraICState extra_state = LoadIC::ComputeExtraICState(contextual_mode);
445 Handle<Code> ic = LoadIC::initialize_stub(isolate(), extra_state); 445 Handle<Code> ic = LoadIC::initialize_stub(isolate(), extra_state);
446 CallIC(ic, contextual_mode, id); 446 CallIC(ic, id);
447 } 447 }
448 448
449 449
450 void FullCodeGenerator::CallStoreIC(ContextualMode mode, TypeFeedbackId id) { 450 void FullCodeGenerator::CallStoreIC(TypeFeedbackId id) {
451 Handle<Code> ic = StoreIC::initialize_stub(isolate(), strict_mode()); 451 Handle<Code> ic = StoreIC::initialize_stub(isolate(), strict_mode());
452 CallIC(ic, mode, id); 452 CallIC(ic, id);
453 } 453 }
454 454
455 455
456 void FullCodeGenerator::RecordJSReturnSite(Call* call) { 456 void FullCodeGenerator::RecordJSReturnSite(Call* call) {
457 // We record the offset of the function return so we can rebuild the frame 457 // We record the offset of the function return so we can rebuild the frame
458 // if the function was inlined, i.e., this is the return address in the 458 // if the function was inlined, i.e., this is the return address in the
459 // inlined function's frame. 459 // inlined function's frame.
460 // 460 //
461 // The state is ignored. We defensively set it to TOS_REG, which is the 461 // The state is ignored. We defensively set it to TOS_REG, which is the
462 // real state of the unoptimized code at the return site. 462 // real state of the unoptimized code at the return site.
(...skipping 1265 matching lines...) Expand 10 before | Expand all | Expand 10 after
1728 } 1728 }
1729 return true; 1729 return true;
1730 } 1730 }
1731 #endif // DEBUG 1731 #endif // DEBUG
1732 1732
1733 1733
1734 #undef __ 1734 #undef __
1735 1735
1736 1736
1737 } } // namespace v8::internal 1737 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/full-codegen.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698