Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 154113008: Switch from WebDocument::insertUserStyleSheet() to insertStyleSheet(). (Closed)

Created:
6 years, 10 months ago by zino
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Switch from WebDocument::insertUserStyleSheet() to insertStyleSheet(). A UserStyleLevel parameter is no longer used in insertUserStyleSheet() and insertUserStyleSheet() calls just insertStyleSheet() again. blink side: https://codereview.chromium.org/143203006 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250982

Patch Set 1 #

Total comments: 1

Patch Set 2 : split line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M chrome/renderer/extensions/dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
zino
6 years, 10 months ago (2014-02-11 08:13:24 UTC) #1
Finnur
You probably don't need 5 people reviewing this code and I trust the other reviewers' ...
6 years, 10 months ago (2014-02-11 13:16:44 UTC) #2
zino
On 2014/02/11 13:16:44, Finnur wrote: > You probably don't need 5 people reviewing this code ...
6 years, 10 months ago (2014-02-11 14:52:34 UTC) #3
piman
lgtm
6 years, 10 months ago (2014-02-11 21:01:24 UTC) #4
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 10 months ago (2014-02-12 01:55:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/154113008/60001
6 years, 10 months ago (2014-02-12 01:57:24 UTC) #6
zino
The CQ bit was unchecked by jinho.bang@samsung.com
6 years, 10 months ago (2014-02-12 02:17:37 UTC) #7
zino
@Yoyo Zhou, Finnur Could you please review extension files?
6 years, 10 months ago (2014-02-13 03:25:44 UTC) #8
Finnur
LGTM
6 years, 10 months ago (2014-02-13 10:04:35 UTC) #9
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 10 months ago (2014-02-13 10:38:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/154113008/60001
6 years, 10 months ago (2014-02-13 10:38:35 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 14:18:28 UTC) #12
Message was sent while issue was closed.
Change committed as 250982

Powered by Google App Engine
This is Rietveld 408576698