Add quotes around executable pathes in the mini installer

chrome/installer/mini_installer/mini_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // mini_installer.exe is the first exe that is run when chrome is being
 // installed or upgraded. It is designed to be extremely small (~5KB with no
 // extra resources linked) and it has two main jobs:
 //   1) unpack the resources (possibly decompressing some)
 //   2) run the real installer (setup.exe) with appropriate flags.
 //
@@ skipping 205 matching lines @@
 
     if (!StrEndsWith(value.get(), kFullInstallerSuffix) &&
         value.append(kFullInstallerSuffix)) {
       key.WriteValue(kApRegistryValueName, value.get());
     }
   }
 }
 
 // Gets the setup.exe path from Registry by looking the value of Uninstall
 // string.  |size| is measured in wchar_t units.
 bool GetSetupExePathForGuidFromRegistry(bool system_level,

[grt (UTC plus 2), 2014/02/05 03:13:50]

please rename this to GetQuotedSetupExePathForGuidFromRegistry and update the
comment above

[Cris Neckar, 2014/02/06 20:56:23]

Done.

                                         const wchar_t* app_guid,
                                         wchar_t* path,
                                         size_t size) {
   const HKEY root_key = system_level ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   RegKey key;
-  return OpenClientStateKey(root_key, app_guid, KEY_QUERY_VALUE, &key) &&
-      (key.ReadValue(kUninstallRegistryValueName, path, size) == ERROR_SUCCESS);
+  wchar_t unquoted_path[MAX_PATH] = {0};

[grt (UTC plus 2), 2014/02/05 03:13:50]

{0} -> {}

[Cris Neckar, 2014/02/06 20:56:23]

Done.

+  if (!OpenClientStateKey(root_key, app_guid, KEY_QUERY_VALUE, &key) ||
+      (key.ReadValue(kUninstallRegistryValueName,
+                     unquoted_path,
+                     MAX_PATH) != ERROR_SUCCESS)) {

[grt (UTC plus 2), 2014/02/05 03:13:50]

MAX_PATH -> arraysize(unquoted_path)

[Cris Neckar, 2014/02/06 20:56:23]

Done.

+    return false;
+  }
+  if (unquoted_path[0] == '\"')
+    return SafeStrCopy(path, size, unquoted_path);
+
+  return SafeStrCopy(path, size, L"\"") &&
+         SafeStrCat(path, size, unquoted_path) &&

[grt (UTC plus 2), 2014/02/05 03:13:50]

nit: either four-space indent, or add parens for:
  return (blah &&
          bletch &&
          phlam);

[Cris Neckar, 2014/02/06 20:56:23]

Done.

+         SafeStrCat(path, size, L"\"");
 }
 
 // Gets the setup.exe path from Registry by looking the value of Uninstall
 // string.  |size| is measured in wchar_t units.

[grt (UTC plus 2), 2014/02/05 03:13:50]

please rename this to GetQuotedSetupExePathFromRegistry and update the comment
above

[Cris Neckar, 2014/02/06 20:56:23]

Done.

 bool GetSetupExePathFromRegistry(const Configuration& configuration,
                                  wchar_t* path,
                                  size_t size) {
   bool system_level = configuration.is_system_level();
 
   // If this is a multi install, first try looking in the binaries for the path.
   if (configuration.is_multi_install() && GetSetupExePathForGuidFromRegistry(
           system_level, google_update::kMultiInstallAppGuid, path, size)) {
     return true;
   }
@@ skipping 18 matching lines @@
 
   return false;
 }
 
 // Calls CreateProcess with good default parameters and waits for the process
 // to terminate returning the process exit code.
 bool RunProcessAndWait(const wchar_t* exe_path, wchar_t* cmdline,
                        int* exit_code) {
   STARTUPINFOW si = {sizeof(si)};
   PROCESS_INFORMATION pi = {0};
   if (!::CreateProcess(exe_path, cmdline, NULL, NULL, FALSE, CREATE_NO_WINDOW,

[grt (UTC plus 2), 2014/02/05 03:13:50]

if the intent of this CL is to mitigate against bugs resulting from the path to
setup containing spaces, then a better approach would be to pass the path to
setup.exe into this function as |exe_path|.

[Cris Neckar, 2014/02/06 20:56:23]

I like this way better. Done.

                        NULL, NULL, &si, &pi)) {
     return false;
   }
 
   ::CloseHandle(pi.hThread);
 
   bool ret = true;
   DWORD wr = ::WaitForSingleObject(pi.hProcess, INFINITE);
   if (WAIT_OBJECT_0 != wr) {
     ret = false;
@@ skipping 566 matching lines @@
     case 1:
       dest8[count - 1] = c;
   }
 
   while (adjcount-- > 0)  // Copy the rest, 4 bytes/32 bits at a time
     *(dest32++) = fill;
 
   return dest;
 }
 }  // extern "C"