Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1541093002: Email Regular Expression update for exclusion of invalid domain parts (Closed)

Created:
5 years ago by Pranay
Modified:
4 years, 12 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, ramya.v, anujsharma, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalid email address (which has invalid domain) is rejected by Email apps. It should not be detected as email in the first place (as RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1). A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" A dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. atext Reference (http://tools.ietf.org/html/rfc5322#section-3.2.3) Modified the Regex to identify the same, added more unit test cases BUG=571804 Committed: https://crrev.com/d46e6212cf8ad49f1ddb028b661fa27d73aeb774 Cr-Commit-Position: refs/heads/master@{#366901}

Patch Set 1 #

Patch Set 2 : Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/android/email_detector.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/android/email_detector_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Pranay
tedchoc@chromium.org: Please review changes in avi@chromium.org: Please review changes in PTAL Thanks
5 years ago (2015-12-23 10:45:01 UTC) #4
Pranay
@Sanjoy, Please do the peer review, Thanks
5 years ago (2015-12-23 10:51:39 UTC) #6
pals
On 2015/12/23 10:51:39, Pranay wrote: > @Sanjoy, > > Please do the peer review, > ...
5 years ago (2015-12-23 12:41:09 UTC) #10
Avi (use Gerrit)
lgtm
5 years ago (2015-12-24 00:38:43 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541093002/20001
4 years, 12 months ago (2015-12-26 07:25:06 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-26 08:42:11 UTC) #15
Pranay
Checking CQ bit
4 years, 12 months ago (2015-12-26 15:48:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541093002/20001
4 years, 12 months ago (2015-12-26 15:48:42 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-26 15:52:50 UTC) #20
commit-bot: I haz the power
4 years, 12 months ago (2015-12-26 15:53:43 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d46e6212cf8ad49f1ddb028b661fa27d73aeb774
Cr-Commit-Position: refs/heads/master@{#366901}

Powered by Google App Engine
This is Rietveld 408576698