Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1541093002:
Email Regular Expression update for exclusion of invalid domain parts (Closed)
|
Created:
5 years ago by Pranay Modified:
4 years, 12 months ago CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, ramya.v, anujsharma, MRV Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInvalid email address (which has invalid domain) is rejected by Email
apps. It should not be detected as email in the first place (as
RFC standards 5322).
As email apps reject these invalid Email-Addresses, So exclusion of
improper email addresses from getting detected as email Intent, would
definitely improve the User Experience & save user efforts.
As per section 3.4.1 of RFC 5322
(http://tools.ietf.org/html/rfc5322#section-3.4.1).
A domain is consisted as=
"domain = dot-atom / domain-literal / obs-domain"
A dot atom "contains no characters other than atext characters or "."
surrounded by atext characters". Hence, by definition, a dot atom may
not contain two or more consecutive periods.
atext Reference
(http://tools.ietf.org/html/rfc5322#section-3.2.3)
Modified the Regex to identify the same, added more unit test cases
BUG=571804
Committed: https://crrev.com/d46e6212cf8ad49f1ddb028b661fa27d73aeb774
Cr-Commit-Position: refs/heads/master@{#366901}
Patch Set 1 #Patch Set 2 : Patch Set 2 #
Messages
Total messages: 22 (12 generated)
Description was changed from ========== WIP BUG= ========== to ========== BUG=571804 ==========
Description was changed from ========== BUG=571804 ========== to ========== Invalid email address is rejected by Email apps and It should not be detected as per RFC standards Modified the Regex to identify more last as soon as (dot) is emcountered, added more unit test cases BUG=571804 ==========
pranay.kumar@samsung.com changed reviewers: + avi@chromium.org, tedchoc@chromium.org
tedchoc@chromium.org: Please review changes in avi@chromium.org: Please review changes in PTAL Thanks
pranay.kumar@samsung.com changed reviewers: + sanjoy.pal@samsung.com
@Sanjoy, Please do the peer review, Thanks
Description was changed from ========== Invalid email address is rejected by Email apps and It should not be detected as per RFC standards Modified the Regex to identify more last as soon as (dot) is emcountered, added more unit test cases BUG=571804 ========== to ========== Invalid email address (which has invalid domain) is rejected by Email apps and It should not be detected as email in the first place (as per RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1) A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" a dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. Modified the Regex to identify more last as soon as (dot) is encountered, added more unit test cases BUG=571804 ==========
Description was changed from ========== Invalid email address (which has invalid domain) is rejected by Email apps and It should not be detected as email in the first place (as per RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1) A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" a dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. Modified the Regex to identify more last as soon as (dot) is encountered, added more unit test cases BUG=571804 ========== to ========== Invalid email address (which has invalid domain) is rejected by Email apps and It should not be detected as email in the first place (as RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1). A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" a dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. atext Reference(http://tools.ietf.org/html/rfc5322#section-3.2.3) Modified the Regex to identify the same, added more unit test cases BUG=571804 ==========
Description was changed from ========== Invalid email address (which has invalid domain) is rejected by Email apps and It should not be detected as email in the first place (as RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1). A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" a dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. atext Reference(http://tools.ietf.org/html/rfc5322#section-3.2.3) Modified the Regex to identify the same, added more unit test cases BUG=571804 ========== to ========== Invalid email address (which has invalid domain) is rejected by Email apps. It should not be detected as email in the first place (as RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1). A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" A dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. atext Reference (http://tools.ietf.org/html/rfc5322#section-3.2.3) Modified the Regex to identify the same, added more unit test cases BUG=571804 ==========
On 2015/12/23 10:51:39, Pranay wrote: > @Sanjoy, > > Please do the peer review, > > Thanks Looks good.
lgtm
The CQ bit was checked by pranay.kumar@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541093002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Checking CQ bit
The CQ bit was checked by pranay.kumar@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541093002/20001
Message was sent while issue was closed.
Description was changed from ========== Invalid email address (which has invalid domain) is rejected by Email apps. It should not be detected as email in the first place (as RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1). A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" A dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. atext Reference (http://tools.ietf.org/html/rfc5322#section-3.2.3) Modified the Regex to identify the same, added more unit test cases BUG=571804 ========== to ========== Invalid email address (which has invalid domain) is rejected by Email apps. It should not be detected as email in the first place (as RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1). A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" A dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. atext Reference (http://tools.ietf.org/html/rfc5322#section-3.2.3) Modified the Regex to identify the same, added more unit test cases BUG=571804 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Invalid email address (which has invalid domain) is rejected by Email apps. It should not be detected as email in the first place (as RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1). A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" A dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. atext Reference (http://tools.ietf.org/html/rfc5322#section-3.2.3) Modified the Regex to identify the same, added more unit test cases BUG=571804 ========== to ========== Invalid email address (which has invalid domain) is rejected by Email apps. It should not be detected as email in the first place (as RFC standards 5322). As email apps reject these invalid Email-Addresses, So exclusion of improper email addresses from getting detected as email Intent, would definitely improve the User Experience & save user efforts. As per section 3.4.1 of RFC 5322 (http://tools.ietf.org/html/rfc5322#section-3.4.1). A domain is consisted as= "domain = dot-atom / domain-literal / obs-domain" A dot atom "contains no characters other than atext characters or "." surrounded by atext characters". Hence, by definition, a dot atom may not contain two or more consecutive periods. atext Reference (http://tools.ietf.org/html/rfc5322#section-3.2.3) Modified the Regex to identify the same, added more unit test cases BUG=571804 Committed: https://crrev.com/d46e6212cf8ad49f1ddb028b661fa27d73aeb774 Cr-Commit-Position: refs/heads/master@{#366901} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d46e6212cf8ad49f1ddb028b661fa27d73aeb774 Cr-Commit-Position: refs/heads/master@{#366901} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
