third_party/WebKit/Source/core/layout/LayoutReplaced.h - Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutReplaced.h

Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html ('K') | « third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3-expected.txt ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h » ('j') | third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutReplaced.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutReplaced.h b/third_party/WebKit/Source/core/layout/LayoutReplaced.h

index e48ff3a21dc06df2c38d7c1a8e3078987eb9c812..cf61ea775f7bfabb95244c322c02694ea15871cd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutReplaced.h

+++ b/third_party/WebKit/Source/core/layout/LayoutReplaced.h

@@ -104,11 +104,11 @@ protected:

virtual LayoutBox* embeddedContentBox() const { return nullptr; }

+ PositionWithAffinity positionForPoint(const LayoutPoint&) override;

private:

void computePreferredLogicalWidths() final;

- PositionWithAffinity positionForPoint(const LayoutPoint&) final;

bool canBeSelectionLeaf() const override { return true; }

LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer) const final;