Fix invalid selection produced when dragging mouse outside the SVG text element

third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp

 /*
  * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Google, Inc.  All rights reserved.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 26 matching lines @@
 #include "core/layout/svg/LayoutSVGViewportContainer.h"
 #include "core/layout/svg/SVGResources.h"
 #include "core/layout/svg/SVGResourcesCache.h"
 #include "core/paint/PaintLayer.h"
 #include "core/svg/SVGElement.h"
 #include "platform/geometry/TransformState.h"
 #include "platform/graphics/StrokeData.h"
 
 namespace blink {
 
+struct SearchCandidate {
+    SearchCandidate() {}
+    SearchCandidate(LayoutObject* layoutObject, float dist)
+        : candidateLayoutObject(layoutObject)
+        , distance(dist)
+    {
+    }
+    LayoutObject* candidateLayoutObject;
+    float distance;
+};
+
 static inline LayoutRect adjustedEnclosingIntRect(const FloatRect& rect,
     const AffineTransform& rootTransform, float strokeWidthForHairlinePadding)
 {
     FloatRect adjustedRect = rect;
 
     if (strokeWidthForHairlinePadding) {
         // For hairline strokes (stroke-width < 1 in device space), Skia rasterizes up to 0.4(9) off
         // the stroke center. That means enclosingIntRect is not enough - we must also pad to 0.5.
         // This is still fragile as it misses out on CC/DSF CTM components.
         const FloatSize strokeSize = rootTransform.mapSize(
@@ skipping 412 matching lines @@
     ASSERT(layoutObject);
 
     // FIXME: trying to compute a device space transform at record time is wrong. All clients
     // should be updated to avoid relying on this information, and the method should be removed.
     AffineTransform ctm = deprecatedCalculateTransformToLayer(layoutObject) * SubtreeContentTransformScope::currentContentTransformation();
     ctm.scale(layoutObject->document().frameHost()->deviceScaleFactor());
 
     return narrowPrecisionToFloat(sqrt((pow(ctm.xScale(), 2) + pow(ctm.yScale(), 2)) / 2));
 }
 
+static inline bool compareCandidateDistance(const SearchCandidate& r1, const SearchCandidate& r2)
+{
+    return r1.distance < r2.distance;
 }
+
+static inline float distanceToChildLayoutObject(LayoutObject* child, const FloatPoint& point)
+{
+    const AffineTransform& localToParentTransform = child->localToParentTransform();
+    if (!localToParentTransform.isInvertible())
+        return std::numeric_limits<float>::max();
+    FloatPoint childLocalPoint = localToParentTransform.inverse().mapPoint(point);
+    return child->objectBoundingBox().squaredDistanceTo(childLocalPoint);
+}
+
+LayoutObject* SVGLayoutSupport::findClosestLayoutSVGText(LayoutObject* layoutObject, const FloatPoint& point)
+{
+    // Try to find the closest LayoutSVGText. If not find the closest LayoutSVGText, try to search on candidates.
+    LayoutObject* closestLayoutObject = nullptr;
+    float closestDistance = std::numeric_limits<float>::max();
+    Vector<SearchCandidate> candidates;
+    for (LayoutObject* child = layoutObject->slowLastChild(); child; child = child->previousSibling()) {
+        if (child->isSVGText()) {
+            float distance = distanceToChildLayoutObject(child, point);
+            if (distance >= closestDistance)
+                continue;
+            candidates.clear();
+            closestLayoutObject = child;
+            closestDistance = distance;
+            continue;
+        }
+
+        if (child->isSVGContainer() && !layoutObject->isSVGHiddenContainer()) {
+            float distance = distanceToChildLayoutObject(child, point);
+            if (distance > closestDistance)
+                continue;
+            candidates.append(SearchCandidate(child, distance));
+        }
+    }
+
+    if (closestLayoutObject && candidates.isEmpty())

[fs, 2016/01/26 14:24:01]

Now closestLayoutObject need to be considered somehow in the loop below.

[hyunjunekim2, 2016/01/26 14:43:17]

Do you means somehow which check overlap?


Could you give me more a hint?

[hyunjunekim2, 2016/01/26 14:53:17]

I guess that 
if ((!closestLayoutObject || closestLayoutObject) && candidates.isEmpty()))
    return closestLayoutObject;

+        return closestLayoutObject;
+
+    // Sort using the distance between the mouse point and a candidate.
+    // Because if the distance is close, It is high priority to search LayoutSVGText.
+    std::stable_sort(candidates.begin(), candidates.end(), compareCandidateDistance);
+
+    // Try to find the closest LayoutSVGText on candidates.
+    for (SearchCandidate& searchCandidate : candidates) {
+        LayoutObject* candidateLayoutObject = searchCandidate.candidateLayoutObject;
+        FloatPoint candidateLocalPoint = candidateLayoutObject->localToParentTransform().inverse().mapPoint(point);
+        if (LayoutObject* result = findClosestLayoutSVGText(candidateLayoutObject, candidateLocalPoint))
+            return result;
+    }
+
+    return nullptr;
+}
+
+}