third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html - Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html

Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3 .org/1999/xlink" width="400" height="400" style="border: 1px solid black;">

	3 <g>

	4 <text x="130" y="30" font-family="Arial" font-size="10" fill="black">Happy, Web</text>

	5 <text x="130" y="50" font-family="Arial" font-size="10" fill="black">Happy, SVG</text>

	6 <text x="130" y="70" font-family="Arial" font-size="10" fill="black">Happy, ;)link</text>

	7 </g>

	8 <text id="line" x="130" y="150" font-family="Arial" font-size="10" fill="black ">Hello World. Hello, SVG.</text>

	9 </svg>

	10 <script src="../../resources/js-test.js"></script>

	11 <script src="resources/SelectionTestCase.js"></script>

	12 <script type="text/javascript">

	13 var range;

	14 function runTest() {

	15 selectTextFromCharToPoint({ id: 'line', offset: 0 }, { x: 300, y: 300 }, { sta rt: "0", end: "24" });

	16 selectTextFromCharToPoint({ id: 'line', offset: 6 }, { x: 300, y: 300 }, { sta rt: "6", end: "24" });

	17 selectTextFromCharToPoint({ id: 'line', offset: 12 }, { x: 300, y: 300 }, { st art: "12", end: "24" });

	18 }

	19

	20 function selectTextFromCharToPoint(selectionInfo, mouse, expectedRange) {

	21 var element = document.getElementById(selectionInfo.id);

	22 var startPos = element.getStartPositionOfChar(selectionInfo.offset);

	23 var absStartPos = toAbsoluteCoordinates(startPos, element);

	24 if (window.eventSender) {

	25 eventSender.mouseMoveTo(absStartPos.x, absStartPos.y);

	26 eventSender.mouseDown();

	27 eventSender.mouseMoveTo(mouse.x, mouse.y);

	28 eventSender.mouseUp();

	29 }

	30 verify(expectedRange.start, expectedRange.end);

	31 }

	32

	33 function verify(start, end) {
	fs 2016/01/25 15:31:28 Just include this directly in the above. No need f Just include this directly in the above. No need for a separate function. For improved utility I think you'll also need to specify (and check) the start/end element of the range.
	34 range = window.getSelection().getRangeAt(0);

	35 shouldBe("range.startOffset", start);

	36 shouldBe("range.endOffset", end);

	37 if (window.eventSender) {

	38 eventSender.mouseMoveTo(0,0);

	39 eventSender.mouseDown();

	40 eventSender.mouseUp();

	41 }

	42 }

	43

	44 runTest();

	45 </script>

OLD	NEW