third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html - Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html

Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1-expected.txt » ('j') | third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3 .org/1999/xlink" width="400" height="400" style="border: 1px solid black;">

	3 <g>

	4 <text x="130" y="30" font-family="Arial" font-size="10" fill="black">Happy, Web</text>

	5 <text x="130" y="50" font-family="Arial" font-size="10" fill="black">Happy, SVG</text>

	6 <text x="130" y="70" font-family="Arial" font-size="10" fill="black">Happy, ;)link</text>

	7 </g>

	8 <text id="line" x="130" y="150" font-family="Arial" font-size="10" fill="black ">Hello World. Hello, SVG.</text>

	9 </svg>

	10 <script src="../../resources/js-test.js"></script>

	11 <script src="resources/SelectionTestCase.js"></script>

	12 <script type="text/javascript">

	13 var range;

	14 function runTest() {

	15 selectText('line', 0, 10);

	16 verify("0", "11");

	17

	18 selectText('line', 6, 10);

	19 verify("6", "11");

	20

	21 selectText('line', 12, 23);

	22 verify("12", "24");

	23

	24 selectText('line', 0, 23);

	25 verify("0", "24");

	26 }

	27 function verify(start, end) {
	fs 2016/01/25 13:00:56 Rather than copying these helpers to all test, put Rather than copying these helpers to all test, put them in SelectionTestCase.js and reuse. They should preferably get some more descriptive names. I wonder if it wouldn't make for better testing to not tie both of the test points to the same element, so maybe: selectTextFromCharToPoint({ element: 'line', offset: 12 }, { x: ..., y: ... }, ...expected range...); (which folds verify into the same function.)
	28 range = window.getSelection().getRangeAt(0);

	29 shouldBe("range.startOffset", start);

	30 shouldBe("range.endOffset", end);

	31 if (window.eventSender) {

	32 eventSender.mouseMoveTo(0,0);

	33 eventSender.mouseDown();

	34 eventSender.mouseUp();

	35 }

	36 }

	37

	38 function selectText(id, start, end) {

	39 var element = document.getElementById(id);

	40 var startPos = element.getStartPositionOfChar(start);

	41 startPos.y += (element.getBBox().height * 1.5);

	42 var endPos = element.getEndPositionOfChar(end);

	43 endPos.y += (element.getBBox().height * 1.5);

	44 var absStartPos = toAbsoluteCoordinates(startPos, element);

	45 var absEndPos = toAbsoluteCoordinates(endPos, element);

	46 if (window.eventSender) {

	47 eventSender.mouseMoveTo(absStartPos.x, absStartPos.y);

	48 eventSender.mouseDown();

	49 eventSender.mouseMoveTo(absEndPos.x, absStartPos.y);

	50 eventSender.mouseUp();

	51 }

	52 }

	53 runTest();

	54 </script>

OLD	NEW