Fix invalid selection produced when dragging mouse outside the SVG text element

third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp

 /*
  * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Google, Inc.  All rights reserved.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 458 matching lines @@
     ASSERT(layoutObject);
 
     // FIXME: trying to compute a device space transform at record time is wrong. All clients
     // should be updated to avoid relying on this information, and the method should be removed.
     AffineTransform ctm = deprecatedCalculateTransformToLayer(layoutObject) * SubtreeContentTransformScope::currentContentTransformation();
     ctm.scale(layoutObject->document().frameHost()->deviceScaleFactor());
 
     return narrowPrecisionToFloat(sqrt((pow(ctm.xScale(), 2) + pow(ctm.yScale(), 2)) / 2));
 }
 
+bool SVGLayoutSupport::compareCandidateDistance(const SearchCandidate r1, const SearchCandidate r2)
+{
+    return r1.distance < r2.distance;
 }
+
+LayoutObject* SVGLayoutSupport::findClosestLayoutSVGText(LayoutObject* layoutObject, const FloatPoint& point)
+{
+    // Try to search closest LayoutSVGText on sub-tree of |layoutObject|.
+    // On this level of tree, try to find the closest LayoutSVGText. If not find this level, try to search
+    // next level which is candidates.
+    LayoutObject* closestLayoutObject = nullptr;
+    float closestDistance = std::numeric_limits<float>::max();
+    Vector<SearchCandidate> candidates;
+    for (LayoutObject* child = layoutObject->slowLastChild(); child; child = child->previousSibling()) {
+        if (child->isSVGHiddenContainer() || !child->localToParentTransform().isInvertible())

[fs, 2016/01/21 14:27:15]

Marginally better than before. I think it'd better to explicitly handle the
cases we're interested in and "continue" for the rest.

[hyunjunekim2, 2016/01/21 15:14:05]

I separated it.

+            continue;
+
+        FloatRect boundingBox = child->objectBoundingBox();
+        FloatPoint childLocalPoint = child->localToParentTransform().inverse().mapPoint(point);
+        float distance = boundingBox.squaredDistanceTo(childLocalPoint);
+
+        if (distance >= closestDistance)

[fs, 2016/01/21 14:27:16]

If distance == closestDistance and !child->isSVGText() don't you want to include
the candidate in that case?

[hyunjunekim2, 2016/01/21 15:14:05]

I contained it in that case.

+            continue;
+
+        if (child->isSVGText()) {
+            candidates.clear();
+            closestLayoutObject = child;
+            closestDistance = distance;
+            continue;
+        }
+
+        if (child->isSVGContainer())
+            candidates.append(SearchCandidate(child, distance));
+    }
+
+    // If find LayoutSVGText this level of tree, return it.
+    if (closestLayoutObject && closestLayoutObject->isSVGText())
+        return closestLayoutObject;
+
+    // Sort using the distance between the mouse point and a candidate.
+    // Because if the distance is close, It is high priority to search LayoutSVGText.
+    std::stable_sort(candidates.begin(), candidates.end(), compareCandidateDistance);
+
+    // If not find LayoutSVGText on this level of tree, try to search it on sub-tree of |condidate|.
+    // This vector called |candidates| is the sort in order of distance from the mouse point.
+    // If can not find the LayoutSVGText on |candidates|, after all return nullptr.
+    for (SearchCandidate searchCandidate : candidates) {

[fs, 2016/01/21 14:27:16]

Use reference.

+        LayoutObject* candidateLayoutObject = searchCandidate.candidateLayoutObject;
+        FloatPoint candidateLocalPoint = candidateLayoutObject->localToParentTransform().inverse().mapPoint(point);
+        if (LayoutObject* result = findClosestLayoutSVGText(candidateLayoutObject, candidateLocalPoint))
+            return result;
+    }
+
+    return nullptr;
+}
+
+}