third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside.html - Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside.html

Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-expected.txt » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3 .org/1999/xlink" width="400" height="400" style="border: 1px solid black;">

	3 <text id="line" x="130" y="150" font-family="Arial" font-size="10" fill="black ">Hello World. Hello, SVG.</text>

	4 </svg>

	5 <script src="../../resources/js-test.js"></script>

	6 <script src="resources/SelectionTestCase.js"></script>

	7 <script type="text/javascript">

	8 var range;

	9 function runTest() {

	10 selectText('line', 0, 10);

	11 verify("0", "11");

	12

	13 selectText('line', 0, 10, true);

	14 verify("0", "24");

	15

	16 selectText('line', 6, 10);

	17 verify("6", "11");

	18

	19 selectText('line', 6, 10, true);

	20 verify("6", "24");

	21

	22 selectText('line', 12, 23);

	23 verify("12", "24");

	24

	25 selectText('line', 12, 23, true);

	26 verify("12", "24");

	27

	28 selectText('line', 20, 23);

	29 verify("20", "24");

	30

	31 selectText('line', 20, 23, true);

	32 verify("20", "24");

	33 }

	34 function verify(start, end) {

	35 range = window.getSelection().getRangeAt(0);

	36 shouldBe("range.startOffset", start);

	37 shouldBe("range.endOffset", end);

	38 if (window.eventSender) {

	39 eventSender.mouseMoveTo(0,0);

	40 eventSender.mouseDown();

	41 eventSender.mouseUp();

	42 }

	43 }

	44

	45 function selectText(id, start, end, mouseX) {

	46 var element = document.getElementById(id);

	47 var startPos = element.getStartPositionOfChar(start);

	48 var endPos = element.getEndPositionOfChar(end);

	49 var absStartPos = toAbsoluteCoordinates(startPos, element);

	50 var absEndPos = toAbsoluteCoordinates(endPos, element);

	51 if (window.eventSender) {

	52 eventSender.mouseMoveTo(absStartPos.x, 350);

	53 eventSender.mouseDown();

	54 if (mouseX)

	55 eventSender.mouseMoveTo(400, 350);

	56 else

	57 eventSender.mouseMoveTo(absEndPos.x, 350);

	58 eventSender.mouseUp();

	59 }

	60 }

	61 runTest();

	62 </script>

OLD	NEW