third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html - Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html

Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html ('K') | « third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3 .org/1999/xlink" width="400" height="400" viewBox="0 0 350 350" style="border: 1 px solid black;">

	3 <g>

	4 <text x="10" y="70" font-family="Arial" font-size="10" fill="black">Hello Wo rld. Hello, SVG.</text>

	5 </g>

	6 <g transform="translate(50, 50)">

	7 <g transform="rotate(20) scale(2)">

	8 <text id="line1" x="10" y="70" font-family="Arial" font-size="10" fill=" black">Hello World. Hello, SVG.</text>
	fs 2016/02/15 14:11:24 Maybe consider using text content of differing len Maybe consider using text content of differing lengths so that moving up/down does not does not guarantee a "hit". Also, inconsisten indent of these two <text>s (4 vs. 2) hyunjunekim2 2016/02/15 16:08:12 Done. Show quoted text On 2016/02/15 14:11:24, fs wrote: > Maybe consider using text content of differing lengths so that moving up/down > does not does not guarantee a "hit". > > Also, inconsisten indent of these two <text>s (4 vs. 2) Done.
	9 <text id="line2" x="10" y="80" font-family="Arial" font-size="10" fill=" black">Hello World. Hello, SVG.</text>

	10 </g>

	11 </g>

	12 </svg>

	13 <script src="../../resources/js-test.js"></script>

	14 <script src="resources/SelectionTestCase.js"></script>

	15 <script type="text/javascript">

	16 function getEndPosition(id, offset, gap) {

	17 var element = document.getElementById(id);

	18 var endPos = element.getEndPositionOfChar(offset);

	19 endPos.x += gap.x;

	20 endPos.y += gap.y;

	21 var absEndPos = toAbsoluteCoordinates(endPos, element);

	22 return absEndPos;

	23 }

	24

	25 var absEndPos = getEndPosition('line1', 10, { x : 0, y : -20});

	26 selectTextFromCharToPoint({ id: 'line1', offset: 0 }, absEndPos, { startElementI d: "line1", start: "0", endElementId: "line1", end: "11" });

	27 absEndPos = getEndPosition('line1', 23, { x : 0, y : -20});

	28 selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementI d: "line1", start: "7", endElementId: "line1", end: "24" });

	29 absEndPos = getEndPosition('line2', 10, { x : 0, y : 20});

	30 selectTextFromCharToPoint({ id: 'line2', offset: 0 }, absEndPos, { startElementI d: "line2", start: "0", endElementId: "line2", end: "11" });

	31 absEndPos = getEndPosition('line2', 23, { x : 0, y : 20});

	32 selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementI d: "line2", start: "7", endElementId: "line2", end: "24" });

	33 absEndPos = getEndPosition('line2', 10, { x : 0, y : 20});

	34 selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementI d: "line1", start: "7", endElementId: "line2", end: "11" });

	35 absEndPos = getEndPosition('line1', 20, { x : 0, y : -20});

	36 selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementI d: "line2", start: "7", endElementId: "line1", end: "21" });

	37 </script>

OLD	NEW