third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html - Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html

Issue 1541083002: Fix invalid selection produced when dragging mouse outside the SVG text element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js ('K') | « third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js ('k') | third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1-expected.txt » ('j') | third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3 .org/1999/xlink" width="400" height="400" style="border: 1px solid black;">
	fs 2016/02/15 14:11:24 Nit/Pro-tip: You don't need 'version' or any of th Nit/Pro-tip: You don't need 'version' or any of the NS-declarations (the former because it's useless - the latter because they're implicitly added by the HTML parser.) (This applies to all the tests) hyunjunekim2 2016/02/15 16:08:11 Done. Show quoted text On 2016/02/15 14:11:24, fs wrote: > Nit/Pro-tip: You don't need 'version' or any of the NS-declarations (the former > because it's useless - the latter because they're implicitly added by the HTML > parser.) > > (This applies to all the tests) Done.
	3 <g>

	4 <text x="130" y="30" font-family="Arial" font-size="10" fill="black">Happy, Web</text>
	fs 2016/02/15 14:11:24 Specifying the style for the <text>s in either a < Specifying the style for the <text>s in either a <style> or on <svg> would make the tests less cluttered. (This applies to all the tests) hyunjunekim2 2016/02/15 16:08:12 Done. Show quoted text On 2016/02/15 14:11:24, fs wrote: > Specifying the style for the <text>s in either a <style> or on <svg> would make > the tests less cluttered. > > (This applies to all the tests) Done.
	5 <text x="130" y="50" font-family="Arial" font-size="10" fill="black">Happy, SVG</text>

	6 <text x="130" y="70" font-family="Arial" font-size="10" fill="black">Happy, ;)link</text>

	7 </g>

	8 <text id="line" x="130" y="150" font-family="Arial" font-size="10" fill="black ">Hello World. Hello, SVG.</text>

	9 </svg>

	10 <script src="../../resources/js-test.js"></script>

	11 <script src="resources/SelectionTestCase.js"></script>

	12 <script type="text/javascript">

	13 selectTextFromCharToPoint({ id: 'line', offset: 0 }, { x: 300, y: 300 }, { start ElementId: 'line', start: "0", endElementId: "line", end: "24" });

	14 selectTextFromCharToPoint({ id: 'line', offset: 6 }, { x: 300, y: 300 }, { start ElementId: "line", start: "6", endElementId: "line", end: "24" });

	15 selectTextFromCharToPoint({ id: 'line', offset: 12 }, { x: 300, y: 300 }, { star tElementId: "line", start: "12", endElementId: "line", end: "24" });
	fs 2016/02/15 14:11:24 Maybe also add some case where selection is starte Maybe also add some case where selection is started at the top and then progressively moved down along a vertical line. I.e something like: ...({ id: 'firsttext', offset: 0 }, { x: <somevalue within the texts>, y: 20 }, ...); ...({ id: 'firsttext', offset: 0 }, { x: <somevalue within the texts>, y: 30 }, ...); ...({ id: 'firsttext', offset: 0 }, { x: <somevalue within the texts>, y: 40 }, ...); ...({ id: 'firsttext', offset: 0 }, { x: <somevalue within the texts>, y: 50 }, ...); ... hyunjunekim2 2016/02/15 16:08:12 fs, I used writing-mode: tb; for vertical. ref to fs, I used writing-mode: tb; for vertical. ref to 'text-selection-align-05-b.svg' and 'text-selection-align-06-b.svg'. But it has bug don't select text also inside text. Could you give me advice? hyunjunekim2 2016/02/17 13:35:48 Done. Show quoted text On 2016/02/15 16:08:12, hyunjunekim2 wrote: > fs, I used writing-mode: tb; for vertical. ref to > 'text-selection-align-05-b.svg' and 'text-selection-align-06-b.svg'. > But it has bug don't select text also inside text. > Could you give me advice? Done.
	16 </script>

OLD	NEW