Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Unified Diff: runtime/vm/service.cc

Issue 1541073002: Implement safepointing of threads (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address-code-review-comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 631a4ec96c50da5bf7d08b7cfbaf82452cc168be..c88b43ffab1f0e31f306be27ffe86ab213ff21ab 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -142,6 +142,8 @@ bool Service::ListenStream(const char* stream_id) {
}
}
if (stream_listen_callback_) {
+ Thread* T = Thread::Current();
+ TransitionVMToNative transition(T);
return (*stream_listen_callback_)(stream_id);
}
return false;
@@ -162,12 +164,15 @@ void Service::CancelStream(const char* stream_id) {
}
}
if (stream_cancel_callback_) {
+ Thread* T = Thread::Current();
+ TransitionVMToNative transition(T);
return (*stream_cancel_callback_)(stream_id);
}
}
RawObject* Service::RequestAssets() {
Thread* T = Thread::Current();
+ TransitionVMToNative transition(T);
Api::Scope api_scope(T);
if (get_service_assets_callback_ == NULL) {
return Object::null();

Powered by Google App Engine
This is Rietveld 408576698