Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: runtime/vm/object.cc

Issue 1541073002: Implement safepointing of threads (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-review-comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 85fdf7e4e2085c84d2dc8658a014b5614b83d281..b6e355d520ee930ec6946bbe88c1eb13f71fb2d5 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -2797,8 +2797,7 @@ class CHACodeArray : public WeakCodeReferences {
#if defined(DEBUG)
static bool IsMutatorOrAtSafepoint() {
Thread* thread = Thread::Current();
- return thread->IsMutatorThread() ||
- thread->isolate()->thread_registry()->AtSafepoint();
+ return thread->IsMutatorThread() || thread->IsAtSafepoint();
}
#endif
@@ -10774,7 +10773,6 @@ bool LibraryPrefix::LoadLibrary() const {
} else if (deferred_lib.LoadNotStarted()) {
Thread* thread = Thread::Current();
Isolate* isolate = thread->isolate();
- Api::Scope api_scope(thread);
Zone* zone = thread->zone();
deferred_lib.SetLoadRequested();
const GrowableObjectArray& pending_deferred_loads =
@@ -10783,9 +10781,13 @@ bool LibraryPrefix::LoadLibrary() const {
pending_deferred_loads.Add(deferred_lib);
const String& lib_url = String::Handle(zone, deferred_lib.url());
Dart_LibraryTagHandler handler = isolate->library_tag_handler();
- handler(Dart_kImportTag,
- Api::NewHandle(thread, importer()),
- Api::NewHandle(thread, lib_url.raw()));
+ {
+ TransitionVMToNative transition(thread);
+ Api::Scope api_scope(thread);
+ handler(Dart_kImportTag,
+ Api::NewHandle(thread, importer()),
+ Api::NewHandle(thread, lib_url.raw()));
+ }
} else {
// Another load request is in flight.
ASSERT(deferred_lib.LoadRequested());

Powered by Google App Engine
This is Rietveld 408576698