Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1541063003: Revert of Auto-rebaseline for r366396 (Closed)

Created:
5 years ago by Finnur
Modified:
5 years ago
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Auto-rebaseline for r366396 (patchset #1 id:1 of https://codereview.chromium.org/1544763002/ ) Reason for revert: Tree really unhappy with the block-layout-inline-children-replaced.html failing all over the place. Example failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/44117/steps/webkit_tests/logs/stdio Original issue's description: > Auto-rebaseline for r366396 > > https://chromium.googlesource.com/chromium/src/+/c2c4f22ff > > BUG=537638 > TBR=mstensho@opera.com > > Committed: https://chromium.googlesource.com/chromium/src/+/8d64809f1d964a249c875c777f89b32db6b03519 TBR=mstensho@opera.com,wkorman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537638 Committed: https://crrev.com/82e4040e3f48430c2e5bbfaa01109cb5b4411b0f Cr-Commit-Position: refs/heads/master@{#366587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -823 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +120 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/block-layout-inline-children-replaced-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/bugzilla-3509-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/clipped-relative-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/float-overflow-expected.txt View 14 chunks +2 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/float-overflow-right-expected.txt View 14 chunks +2 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/outline-change-invalidation-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/outline-clip-change-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-body-appear-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/positioned-great-grandparent-change-location-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/positioned-list-offset-change-repaint-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/repaint-descandant-on-ancestor-layer-move-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/replaced-clipped-positioned-not-wrong-incremental-repainting-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-removal-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/transform-inline-layered-child-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/vertical-align2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/compositing/repaint/should-not-clip-composited-viewport-scrolling-layer-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/css3/flexbox/repaint-expected.txt View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/forms/button/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/forms/submit/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/repaint/block-layout-inline-children-replaced-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/table/resize-table-repaint-percent-size-cell-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/table/resize-table-repaint-vertical-align-cell-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/table/resize-table-row-repaint-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/as-image/svg-image-change-content-size-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/absolute-sized-content-with-resources-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/js-late-clipPath-and-object-creation-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/js-late-clipPath-creation-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/js-late-gradient-and-object-creation-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/js-late-gradient-creation-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/js-late-pattern-and-object-creation-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/js-late-pattern-creation-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/relative-sized-content-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/relative-sized-content-with-resources-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/relative-sized-image-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/relative-sized-inner-svg-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/relative-sized-shadow-tree-content-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
wkorman
lgtm The test you mention causing problems is I think unrelated to mstensho@'s work, it ...
5 years ago (2015-12-22 11:31:59 UTC) #1
wkorman
On 2015/12/22 at 11:31:59, wkorman wrote: > lgtm > > The test you mention causing ...
5 years ago (2015-12-22 11:37:24 UTC) #2
wkorman
On 2015/12/22 at 11:37:24, wkorman wrote: > On 2015/12/22 at 11:31:59, wkorman wrote: > > ...
5 years ago (2015-12-22 11:42:35 UTC) #3
Finnur
I've been unable to revert (keep getting 500 server error).
5 years ago (2015-12-22 11:44:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541063003/1
5 years ago (2015-12-22 11:50:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 11:52:04 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/82e4040e3f48430c2e5bbfaa01109cb5b4411b0f Cr-Commit-Position: refs/heads/master@{#366587}
5 years ago (2015-12-22 11:52:54 UTC) #10
Finnur
Finally. :)
5 years ago (2015-12-22 12:00:28 UTC) #11
Noel Gordon
On 2015/12/22 12:00:28, Finnur wrote: > Finally. :) Maybe look at the tree right now, ...
5 years ago (2015-12-22 12:02:03 UTC) #12
Noel Gordon
On 2015/12/22 12:02:03, noel gordon wrote: > On 2015/12/22 12:00:28, Finnur wrote: > > Finally. ...
5 years ago (2015-12-22 12:03:40 UTC) #13
Noel Gordon
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1546593002/ by noel@chromium.org. ...
5 years ago (2015-12-22 12:09:10 UTC) #14
Noel Gordon
On 2015/12/22 12:09:10, noel gordon wrote: > Sometimes test results bounce ... bounce into green, ...
5 years ago (2015-12-22 12:20:19 UTC) #15
Finnur
5 years ago (2015-12-22 12:27:45 UTC) #16
Message was sent while issue was closed.
Hugh... interesting. Sure, reverting is fine. Thanks!

Powered by Google App Engine
This is Rietveld 408576698